Replace bypass-submit with trigger-submit-unchecked (#199)

Bypassing the submit process means that the map revision is not updated.  Change the endpoint and include a flag to skip the map checks but update the revision.

Reviewed-on: #199
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

validation/src/check.rs

@@ -12,6 +12,7 @@ pub enum Error{
 	Download(crate::download::Error),
 	ModelFileDecode(ReadDomError),
 	GetRootInstance(GetRootInstanceError),
+	IntoMapInfoOwned(IntoMapInfoOwnedError),
 	ToJsonValue(serde_json::Error),
 }
 impl std::fmt::Display for Error{
@@ -23,13 +24,15 @@ impl std::error::Error for Error{}
 
 #[allow(nonstandard_style)]
 pub struct CheckRequest{
-	pub ModelID:u64,
+	ModelID:u64,
+	SkipChecks:bool,
 }
 
 impl From<crate::nats_types::CheckMapfixRequest> for CheckRequest{
 	fn from(value:crate::nats_types::CheckMapfixRequest)->Self{
 		Self{
 			ModelID:value.ModelID,
+			SkipChecks:value.SkipChecks,
 		}
 	}
 }
@@ -37,6 +40,7 @@ impl From<crate::nats_types::CheckSubmissionRequest> for CheckRequest{
 	fn from(value:crate::nats_types::CheckSubmissionRequest)->Self{
 		Self{
 			ModelID:value.ModelID,
+			SkipChecks:value.SkipChecks,
 		}
 	}
 }
@@ -382,6 +386,22 @@ pub struct MapInfoOwned{
 	pub creator:String,
 	pub game_id:GameID,
 }
+#[derive(Debug)]
+pub enum IntoMapInfoOwnedError{
+	DisplayName(StringValueError),
+	Creator(StringValueError),
+	GameID(ParseGameIDError),
+}
+impl TryFrom<MapInfo<'_>> for MapInfoOwned{
+	type Error=IntoMapInfoOwnedError;
+	fn try_from(value:MapInfo<'_>)->Result<Self,Self::Error>{
+		Ok(Self{
+			display_name:value.display_name.map_err(IntoMapInfoOwnedError::DisplayName)?.to_owned(),
+			creator:value.creator.map_err(IntoMapInfoOwnedError::Creator)?.to_owned(),
+			game_id:value.game_id.map_err(IntoMapInfoOwnedError::GameID)?,
+		})
+	}
+}
 
 // Named dummy types for readability
 struct Exists;
@@ -833,6 +853,17 @@ impl crate::message_handler::MessageHandler{
 		// extract the root instance
 		let model_instance=get_root_instance(&dom).map_err(Error::GetRootInstance)?;
 
+		// skip checks
+		if check_info.SkipChecks{
+			// extract required fields
+			let map_info=get_mapinfo(&dom,model_instance);
+			let map_info_owned=map_info.try_into().map_err(Error::IntoMapInfoOwned)?;
+			let status=Ok(map_info_owned);
+
+			// return early
+			return Ok(CheckReportAndVersion{status,version});
+		}
+
 		// extract information from the model
 		let model_info=get_model_info(&dom,model_instance);
 

validation/src/nats_types.rs

@@ -34,6 +34,7 @@ pub struct CreateMapfixRequest{
 pub struct CheckSubmissionRequest{
 	pub SubmissionID:SubmissionID,
 	pub ModelID:u64,
+	pub SkipChecks:bool,
 }
 
 #[allow(nonstandard_style)]
@@ -41,6 +42,7 @@ pub struct CheckSubmissionRequest{
 pub struct CheckMapfixRequest{
 	pub MapfixID:MapfixID,
 	pub ModelID:u64,
+	pub SkipChecks:bool,
 }
 
 #[allow(nonstandard_style)]