Asset ID grabbed at submitting but no indicator of model updates

littlefarrell commented

2025-06-09 02:29:00 +00:00

The ID is grabbed when the mapfix is submitted, but no indicator is made to the model being updated, so map council will only be able to test the current model of the map, but not the actual one that would be pushed to the database. In theory someone could upload a model ID with nothing in it, update it to have the mapfix, and then a council member would see the updated fix and accidentally push a model with nothing in it to main.
Optionally this could either be resolved by:

Having a warning on the site when the model is updated, and an ID to use of the one locked into the database,
or
Re-updating the model upon validation

The ID is grabbed when the mapfix is submitted, but no indicator is made to the model being updated, so map council will only be able to test the current model of the map, but not the actual one that would be pushed to the database. In theory someone could upload a model ID with nothing in it, update it to have the mapfix, and then a council member would see the updated fix and accidentally push a model with nothing in it to main. Optionally this could either be resolved by: 1. Having a warning on the site when the model is updated, and an ID to use of the one locked into the database, or 2. Re-updating the model upon validation

Quaternions referenced a pull request that will close this issue

2025-06-09 02:58:45 +00:00

validation: refuse to validate if model has updates #188

Quaternions commented

2025-06-09 03:02:27 +00:00

Owner

I'm opting to simply prevent this by refusing to validate an updated model. The proper solution will be to load the correct version on maptest. You will have to manually punt the "Script Review" models back with the Changes Requested button when the RevisionMismatch error shows up for the time being, get the submitter to resubmit, and reaccept.

I'm opting to simply prevent this by refusing to validate an updated model. The proper solution will be to load the correct version on maptest. You will have to manually punt the "Script Review" models back with the `Changes Requested` button when the `RevisionMismatch` error shows up for the time being, get the submitter to resubmit, and reaccept.

Quaternions closed this issue

2025-06-09 03:04:34 +00:00

Quaternions referenced this issue from a commit

2025-06-09 03:04:36 +00:00

validation: refuse to validate if model has updates (#188)

Asset ID grabbed at submitting but no indicator of model updates #187