Make Validation Checks Orthogonal to Review

Quaternions commented

2025-12-27 04:13:15 +00:00

Owner

Brainstorming an idea in real time here. Maps should generally not be "accepted" more than once, unless an issue is discovered after accepting that sends the map back to changes requested. However, I find myself regularly doing this to request script changes. Come to think of it, anything in the map could change when the model is updated, so it does effectively need to be reviewed from scratch...

Maps should be able to be rechecked at multiple review stages. For example, it's a problem that maps have to be sent back across the "accepted" barrier when I request script changes, in order to re-run the checks. So map checking should be possible orthogonally to the review pipeline, making the "Submitting" status unnecessary.

Components:

Somehow check maps using a check button available in the AcceptedUnvalidated status
Auto-run the check if the map is being submitted
Do not auto-run the check on re-validation, since it re-grabs the latest version

Workarounds:

#280 Just add a new status between AcceptedUnvalidated and Validated to run the checks...

In the end I'm not entirely sure if this is necessary or even a problem.

Brainstorming an idea in real time here. Maps should generally not be "accepted" more than once, unless an issue is discovered after accepting that sends the map back to changes requested. However, I find myself regularly doing this to request script changes. Come to think of it, anything in the map could change when the model is updated, so it does effectively need to be reviewed from scratch... Maps should be able to be rechecked at multiple review stages. For example, it's a problem that maps have to be sent back across the "accepted" barrier when I request script changes, in order to re-run the checks. So map checking should be possible orthogonally to the review pipeline, making the "Submitting" status unnecessary. Components: - Somehow check maps using a check button available in the AcceptedUnvalidated status - Auto-run the check if the map is being submitted - Do not auto-run the check on re-validation, since it re-grabs the latest version Workarounds: - #280 Just add a new status between AcceptedUnvalidated and Validated to run the checks... In the end I'm not entirely sure if this is necessary or even a problem.

Quaternions added the backend label 2025-12-27 04:14:08 +00:00

Quaternions changed title from ~~Validation Checks are Orthogonal to Review~~ to Make Validation Checks Orthogonal to Review

2025-12-27 04:16:20 +00:00

Quaternions commented

2025-12-27 20:20:19 +00:00

Author

Owner

This is actually a different solution to the same issue as #280

Quaternions commented

2025-12-27 23:19:30 +00:00

Author

Owner

This is dumb, the validation is not actually orthogonal. The map maker should pass the checks before the map can be submitted, I just need to be able to run the checks again when they make changes after it's accepted. Closing in favour of #280.

Quaternions closed this issue

2025-12-27 23:19:30 +00:00

Make Validation Checks Orthogonal to Review #296