Submissions Webpage List Filter #44

Closed
opened 2025-03-29 01:18:22 +00:00 by Quaternions · 5 comments
Owner

The maps list webpage https://maps.staging.strafes.net/submissions needs to be filterable.

The most notable (backend) implementation detail is that submissions "UnderConstruction" are completely private to the submitter and cannot be accessed by anyone other than the submitter themselves.

Drop-down / text box filters for:

  • status_id (bitflags? array?) check out the gitea issue "Labels" on the right column of this issue for an example!
  • target_asset_id (view historical and active mapfixes for a particular map) search main game maps
  • submitter
  • game_id

Filter presets:

  • "My Submissions"
    • Filter ?Submitter= currently logged in user
  • "Active Submissions":
    • StatusUploading
    • StatusValidated
    • StatusValidating
    • StatusAccepted
    • StatusChangesRequested
    • StatusSubmitted

Backend implementation:

  • /api/submissions endpoint is restricted to non - UnderConstruction submissions and has no authentication. Otherwise identical to the previous /api/submissions endpoint which has no restrictions.
  • /api/submissions-by-me endpoint displays only submissions by the authenticated user, and has no status restrictions.
The maps list webpage https://maps.staging.strafes.net/submissions needs to be filterable. The most notable (backend) implementation detail is that submissions "UnderConstruction" are completely private to the submitter and cannot be accessed by anyone other than the submitter themselves. Drop-down / text box filters for: - status_id (bitflags? array?) check out the gitea issue "Labels" on the right column of this issue for an example! - target_asset_id (view historical and active mapfixes for a particular map) search main game maps - submitter - game_id Filter presets: - "My Submissions" - Filter ?Submitter= currently logged in user - "Active Submissions": - StatusUploading - StatusValidated - StatusValidating - StatusAccepted - StatusChangesRequested - StatusSubmitted Backend implementation: - `/api/submissions` endpoint is restricted to non - UnderConstruction submissions and has no authentication. Otherwise identical to the previous `/api/submissions` endpoint which has no restrictions. - `/api/submissions-by-me` endpoint displays only submissions by the authenticated user, and has no status restrictions.
Quaternions added the backendfrontend labels 2025-03-29 01:31:03 +00:00
Quaternions added this to the 1.0 Release milestone 2025-03-29 05:27:08 +00:00
interpreterK was assigned by Quaternions 2025-03-29 06:00:11 +00:00
ic3w0lf22 was assigned by Quaternions 2025-03-29 06:00:22 +00:00
Quaternions self-assigned this 2025-03-29 06:09:45 +00:00
Quaternions removed this from the 1.0 Release milestone 2025-04-03 22:07:34 +00:00
Quaternions added this to the 1.1 Centralize Maptest milestone 2025-04-03 22:08:46 +00:00
Owner

The most notable (backend) implementation detail is that submissions "UnderConstruction" are completely private to the submitter and cannot be accessed by anyone other than the submitter themselves.

Does this mean by everyone including admin or others?

> The most notable (backend) implementation detail is that submissions "UnderConstruction" are completely private to the submitter and cannot be accessed by anyone other than the submitter themselves. Does this mean by _everyone_ including admin or others?
Owner

I guess do we care about actually hiding the submissions on the backend or is just making the frontend hide them enough?

I guess do we care about actually hiding the submissions on the backend or is just making the frontend hide them enough?
Author
Owner

The goal 9 months ago was to enable map makers to use the website "privately" without revealing their map to everyone. What ended up happening instead was the "take model" feature was never added to the website to replace the discord bot feature that puts the map in the maptest bot inventory. So keeping their map private is possible by developing the map in the maptest place before submitting it to the website. I think at most one person has requested to be able to submit their map privately in the past 9 months, so it may not be necessary at all.

The other consideration would be maptest integration (milestone 3). If later on maptest connects to maps-service and helps you load your most recent map, the ability to use the website privately may be more widely appreciated.

I say we can put off the private submissions until it's requested again and actually needed.

The goal 9 months ago was to enable map makers to use the website "privately" without revealing their map to everyone. What ended up happening instead was the "take model" feature was never added to the website to replace the discord bot feature that puts the map in the maptest bot inventory. So keeping their map private is possible by developing the map in the maptest place before submitting it to the website. I think at most one person has requested to be able to submit their map privately in the past 9 months, so it may not be necessary at all. The other consideration would be maptest integration ([milestone 3](https://git.itzana.me/StrafesNET/maps-service/milestone/3)). If later on maptest connects to maps-service and helps you load your most recent map, the ability to use the website privately may be more widely appreciated. I say we can put off the private submissions until it's requested again and actually needed.
Author
Owner

This is sufficiently addressed by #297 imo, this can be reopened if the submissions list page becomes relevant again.

This is sufficiently addressed by #297 imo, this can be reopened if the submissions list page becomes relevant again.
Owner

I'll probably still add filters but not to the extent this issue details.

I'll probably still add filters but not to the extent this issue details.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#44