StrafesNET/maptest-bot
3
Fork 0
Code Issues Pull Requests Releases Activity

add flytrials #4

Merged
Quaternions merged 2 commits from staging into master 2023-03-19 00:30:54 +00:00
Conversation 8 Commits 2 Files Changed 6 +32 -23
Quaternions commented 2023-03-08 20:39:18 +00:00
Owner
Copy Link

I've never coded in javascript so review my untested code thanks

I've never coded in javascript so review my untested code thanks
Quaternions added 2 commits 2023-03-08 20:39:19 +00:00
use dictionary instead of hardcoded if-else for each game d8a0890e26
add flytrials 3213bfdd91
Quaternions force-pushed staging from 3213bfdd91 to 5681e21fbe 2023-03-08 20:42:50 +00:00 Compare
fiveman1 reviewed 2023-03-08 20:46:33 +00:00
commands/submissions.js Outdated
@@ -4,0 +7,4 @@
deathrun: "files/deathrun_submissions.csv",
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
fiveman1 commented 2023-03-08 20:46:33 +00:00
Member
Copy Link

use const instead of var

use const instead of var
fiveman1 reviewed 2023-03-08 20:47:20 +00:00
commands/submissions.js Outdated
@@ -4,0 +8,4 @@
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
for (const [game, file] of Object.entries(gameDict)) {
fiveman1 commented 2023-03-08 20:47:19 +00:00
Member
Copy Link

I would use Object.keys rather than Object.entries since you aren't using the values

I would use Object.keys rather than Object.entries since you aren't using the values
fiveman1 reviewed 2023-03-08 20:49:41 +00:00
commands/submissions.js Outdated
@@ -10,3 +18,1 @@
else if (game === "surf") fname = "files/surf_submissions.csv";
else if (game === "deathrun") fname = "files/deathrun_submissions.csv";
else {
let fname = gameDict[game];
fiveman1 commented 2023-03-08 20:49:41 +00:00
Member
Copy Link

should be const fname rather than let fname since it won't be reassigned now

should be const fname rather than let fname since it won't be reassigned now
fiveman1 reviewed 2023-03-08 20:50:01 +00:00
commands/submissions.js Outdated
@@ -11,2 +18,2 @@
else if (game === "deathrun") fname = "files/deathrun_submissions.csv";
else {
let fname = gameDict[game];
if (fname === undefined) {
fiveman1 commented 2023-03-08 20:50:01 +00:00
Member
Copy Link

if (!fname) is probably a bit more straightforward

if (!fname) is probably a bit more straightforward
fiveman1 reviewed 2023-03-08 20:52:56 +00:00
commands/submit.js Outdated
@@ -6,0 +9,4 @@
deathrun: "files/deathrun_submissions.csv",
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
fiveman1 commented 2023-03-08 20:52:56 +00:00
Member
Copy Link

any changes need to be applied to each file. would probably be possible to make a new file and move the duplicate code there but not a big deal

any changes need to be applied to each file. would probably be possible to make a new file and move the duplicate code there but not a big deal
Quaternions commented 2023-03-08 21:15:11 +00:00
Author
Owner
Copy Link

doing this now

doing this now
fiveman1 requested changes 2023-03-08 20:54:48 +00:00
fiveman1 left a comment
Member
Copy Link

did this on my phone, only suggestions are just code style

did this on my phone, only suggestions are just code style
Quaternions force-pushed staging from 5681e21fbe to 8fa05099be 2023-03-08 21:19:55 +00:00 Compare
Quaternions commented 2023-03-08 21:23:17 +00:00
Author
Owner
Copy Link

I've incorporated most of the suggestions but redid the whole thing to use a centralized module. I hope I wrote the module export stuff correctly

I've incorporated most of the suggestions but redid the whole thing to use a centralized module. I hope I wrote the module export stuff correctly
Quaternions force-pushed staging from 8fa05099be to 770118d937 2023-03-08 21:24:29 +00:00 Compare
fiveman1 approved these changes 2023-03-08 21:37:17 +00:00
fiveman1 left a comment
Member
Copy Link

Looks good

Looks good
Quaternions force-pushed staging from 770118d937 to ace8e05b67 2023-03-08 22:19:25 +00:00 Compare
Quaternions force-pushed staging from ace8e05b67 to b44dd98976 2023-03-08 22:23:33 +00:00 Compare
Quaternions merged commit 85fd5e9de9 into master 2023-03-19 00:30:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
fiveman1
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
CI fiveman1 itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maptest-bot#4
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?