From 38b3f3d7a3166fb6431a9eb01af9fb4e576069bd Mon Sep 17 00:00:00 2001
From: Rhys Lloyd <krakow20@gmail.com>
Date: Sat, 19 Jul 2025 02:25:55 -0700
Subject: [PATCH] use expect instead of allow

---
 integration-testing/src/error.rs             | 2 +-
 lib/bsp_loader/src/brush.rs                  | 2 +-
 lib/bsp_loader/src/loader.rs                 | 4 ++--
 lib/rbx_loader/src/loader.rs                 | 4 ++--
 lib/rbx_loader/src/mesh.rs                   | 2 +-
 lib/rbx_loader/src/union.rs                  | 2 +-
 lib/roblox_emulator/src/runner/tween.rs      | 2 +-
 lib/roblox_emulator/src/runner/tween_info.rs | 2 +-
 map-tool/src/roblox.rs                       | 6 +++---
 map-tool/src/source.rs                       | 2 +-
 strafe-client/src/file.rs                    | 4 ++--
 11 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/integration-testing/src/error.rs b/integration-testing/src/error.rs
index fbc77dc1..5aba9fbf 100644
--- a/integration-testing/src/error.rs
+++ b/integration-testing/src/error.rs
@@ -1,4 +1,4 @@
-#[allow(unused)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum ReplayError{
 	IO(std::io::Error),
diff --git a/lib/bsp_loader/src/brush.rs b/lib/bsp_loader/src/brush.rs
index a7ce6e1f..35e886c1 100644
--- a/lib/bsp_loader/src/brush.rs
+++ b/lib/bsp_loader/src/brush.rs
@@ -187,7 +187,7 @@ fn planes_to_faces(face_list:std::collections::HashSet<Face>)->Result<Faces,Plan
 	}
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum BrushToMeshError{
 	SliceBrushSides,
diff --git a/lib/bsp_loader/src/loader.rs b/lib/bsp_loader/src/loader.rs
index 8ade595a..9aa204b5 100644
--- a/lib/bsp_loader/src/loader.rs
+++ b/lib/bsp_loader/src/loader.rs
@@ -5,7 +5,7 @@ use strafesnet_deferred_loader::{loader::Loader,texture::Texture};
 
 use crate::{Bsp,Vpk};
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum TextureError{
 	Io(std::io::Error),
@@ -41,7 +41,7 @@ impl Loader for TextureLoader{
 	}
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum MeshError{
 	Io(std::io::Error),
diff --git a/lib/rbx_loader/src/loader.rs b/lib/rbx_loader/src/loader.rs
index 0b322180..a3571fac 100644
--- a/lib/rbx_loader/src/loader.rs
+++ b/lib/rbx_loader/src/loader.rs
@@ -18,7 +18,7 @@ fn read_entire_file(path:impl AsRef<std::path::Path>)->Result<Vec<u8>,std::io::E
 	Ok(data)
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum TextureError{
 	Io(std::io::Error),
@@ -59,7 +59,7 @@ impl Loader for TextureLoader{
 	}
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum MeshError{
 	Io(std::io::Error),
diff --git a/lib/rbx_loader/src/mesh.rs b/lib/rbx_loader/src/mesh.rs
index b8bf55a4..e38cace8 100644
--- a/lib/rbx_loader/src/mesh.rs
+++ b/lib/rbx_loader/src/mesh.rs
@@ -7,7 +7,7 @@ use strafesnet_common::model::{self,ColorId,IndexedVertex,NormalId,PolygonGroup,
 
 use crate::loader::MeshWithSize;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum Error{
 	Planar64Vec3(strafesnet_common::integer::Planar64TryFromFloatError),
diff --git a/lib/rbx_loader/src/union.rs b/lib/rbx_loader/src/union.rs
index f6829a2a..88495114 100644
--- a/lib/rbx_loader/src/union.rs
+++ b/lib/rbx_loader/src/union.rs
@@ -7,7 +7,7 @@ use rbx_mesh::physics_data::VertexId as PhysicsDataVertexId;
 use strafesnet_common::model::{self,IndexedVertex,PolygonGroup,PolygonGroupId,PolygonList,RenderConfigId};
 use strafesnet_common::integer::vec3;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum Error{
 	Block,
diff --git a/lib/roblox_emulator/src/runner/tween.rs b/lib/roblox_emulator/src/runner/tween.rs
index e8441f01..3fffcf59 100644
--- a/lib/roblox_emulator/src/runner/tween.rs
+++ b/lib/roblox_emulator/src/runner/tween.rs
@@ -1,7 +1,7 @@
 use super::instance::Instance;
 use super::tween_info::TweenInfo;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Clone)]
 pub struct Tween{
 	instance:Instance,
diff --git a/lib/roblox_emulator/src/runner/tween_info.rs b/lib/roblox_emulator/src/runner/tween_info.rs
index 6f018cd0..860f169c 100644
--- a/lib/roblox_emulator/src/runner/tween_info.rs
+++ b/lib/roblox_emulator/src/runner/tween_info.rs
@@ -1,7 +1,7 @@
 use super::number::Number;
 use super::r#enum::{CoerceEnum,Enums};
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Clone)]
 pub struct TweenInfo{
 	time:f64,
diff --git a/map-tool/src/roblox.rs b/map-tool/src/roblox.rs
index 03e83daf..44c6cf1d 100644
--- a/map-tool/src/roblox.rs
+++ b/map-tool/src/roblox.rs
@@ -66,7 +66,7 @@ async fn cookie_from_args(literal:Option<String>,environment:Option<String>,file
 	Ok(rbx_asset::cookie::Cookie::new(cookie))
 }
 
-#[allow(unused)]
+#[expect(dead_code)]
 #[derive(Debug)]
 enum LoadDomError{
 	IO(std::io::Error),
@@ -192,7 +192,7 @@ impl UniqueAssets{
 	}
 }
 
-#[allow(unused)]
+#[expect(dead_code)]
 #[derive(Debug)]
 enum UniqueAssetError{
 	IO(std::io::Error),
@@ -421,7 +421,7 @@ async fn download_assets(paths:Vec<PathBuf>,cookie:rbx_asset::cookie::Cookie)->A
 }
 
 #[derive(Debug)]
-#[allow(dead_code)]
+#[expect(dead_code)]
 enum ConvertError{
 	IO(std::io::Error),
 	SNFMap(strafesnet_snf::map::Error),
diff --git a/map-tool/src/source.rs b/map-tool/src/source.rs
index 89a7b069..51f5109b 100644
--- a/map-tool/src/source.rs
+++ b/map-tool/src/source.rs
@@ -452,7 +452,7 @@ fn bsp_contents(path:PathBuf)->AResult<()>{
 }
 
 #[derive(Debug)]
-#[allow(dead_code)]
+#[expect(dead_code)]
 enum ConvertError{
 	IO(std::io::Error),
 	SNFMap(strafesnet_snf::map::Error),
diff --git a/strafe-client/src/file.rs b/strafe-client/src/file.rs
index 6f0fc9eb..81c55c82 100644
--- a/strafe-client/src/file.rs
+++ b/strafe-client/src/file.rs
@@ -3,7 +3,7 @@ use std::io::Read;
 #[cfg(any(feature="roblox",feature="source"))]
 use strafesnet_deferred_loader::deferred_loader::LoadFailureMode;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum ReadError{
 	#[cfg(feature="roblox")]
@@ -63,7 +63,7 @@ pub fn read<R:Read+std::io::Seek>(input:R)->Result<ReadFormat,ReadError>{
 	}
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 #[derive(Debug)]
 pub enum LoadError{
 	ReadError(ReadError),