Mapfix submissions check for title case

numberss commented

2025-06-09 10:17:53 +00:00

Member

Mapfix submissions are for maps that are already in the game, so a title case check is not needed. It should only check if the mapfix DisplayName matches the current DisplayName

Quaternions added the help wanted validator labels 2025-07-22 14:20:37 +00:00

Quaternions commented

2025-07-22 14:33:10 +00:00

Owner

This wouldn't be too big of a change, so it would be a good place to start learning about the website backend.

Detect whether check_inner is called for a mapfix or a submission, probably by adding a field check_against_previous_display_name:Option<String> to CheckRequest and modifying the From impls accordingly
Use the config to replace the display name check with a check against the previous display name, which may need to be plumbed in from the golang backend through the nats object on both sides here and here.

This wouldn't be too big of a change, so it would be a good place to start learning about the website backend. - Detect whether [`check_inner`](https://git.itzana.me/StrafesNET/maps-service/src/commit/740e6368b1d1387091f50314050862a854fc0bbc/validation/src/check.rs#L849) is called for a mapfix or a submission, probably by adding a field `check_against_previous_display_name:Option<String>` to [`CheckRequest`](https://git.itzana.me/StrafesNET/maps-service/src/commit/740e6368b1d1387091f50314050862a854fc0bbc/validation/src/check.rs#L28) and modifying the From impls accordingly - Use the config to replace the [display name check](https://git.itzana.me/StrafesNET/maps-service/src/commit/740e6368b1d1387091f50314050862a854fc0bbc/validation/src/check.rs#L480) with a check against the previous display name, which may need to be plumbed in from the golang backend through the nats object on both sides [here](https://git.itzana.me/StrafesNET/maps-service/src/commit/740e6368b1d1387091f50314050862a854fc0bbc/pkg/model/nats.go#L33) and [here](https://git.itzana.me/StrafesNET/maps-service/src/commit/740e6368b1d1387091f50314050862a854fc0bbc/validation/src/nats_types.rs#L40).

Quaternions referenced a pull request that will close this issue

2026-01-07 19:44:29 +00:00

Check that mapfixes do not change DisplayName, Creator, GameID #324

Mapfix submissions check for title case #189