StrafesNET/maps-service
5
Fork 4
Code Issues 17 Pull Requests 1 Packages Projects Releases Wiki Activity

Check that mapfixes do not change DisplayName, Creator, GameID #324

Open
Quaternions wants to merge 3 commits from mapfix-checks into 50-chars
pull from: mapfix-checks
merge into: StrafesNET:50-chars
Conversation 0 Commits 3 Files Changed 10 +257 -93
Quaternions commented 2026-01-07 19:44:29 +00:00
Owner
Copy Link

Good lord this code is horrible. The nested check() functions constantly swapping argument order back and forth bruh

- Depends on #323 - Closes #189 - Closes #352 Good lord this code is horrible. The nested check() functions constantly swapping argument order back and forth bruh
Quaternions added the validator label 2026-01-07 19:44:29 +00:00
Quaternions added 3 commits 2026-01-07 19:44:29 +00:00
backend: plumb target info into checks 8894231b41
validation: generalize StringEquality to EqualityCheck 9e47ca5177
validation: Check that mapfixes do not change DisplayName, Creator, GameID
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
474655f4a3
Quaternions added a new dependency 2026-01-07 19:44:37 +00:00
#323 Limit DisplayName and Creator to 50 characters
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mapfix-checks:mapfix-checks
git checkout mapfix-checks
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label validator
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge fiveman1 ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#323 Limit DisplayName and Creator to 50 characters
StrafesNET/maps-service
Reference: StrafesNET/maps-service#324
Delete Branch "mapfix-checks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?