StrafesNET/protobufs
5
Fork 1
Code Issues 1 Pull Requests 2 Projects Releases Activity

New Fields For Maps #4

Closed
Quaternions wants to merge 3 commits from maps-fields into master
pull from: maps-fields
merge into: StrafesNET:master
Conversation 2 Commits 3 Files Changed 1 +8 -2
Quaternions commented 2025-06-22 03:07:33 +00:00
Owner
Copy Link

This is based on StrafesNET/data-service#25

Thumbnail and AssetVersion are future features that are not yet implemented in the game or maps service.

I'm debating whether it makes sense to add all the features at once or as needed.

This is based on https://git.itzana.me/StrafesNET/data-service/issues/25 Thumbnail and AssetVersion are future features that are not yet implemented in the game or maps service. I'm debating whether it makes sense to add all the features at once or as needed.
Quaternions added 3 commits 2025-06-22 03:07:34 +00:00
add new fields to maps 1f5668308c
thumbnail doesn't make sense as a filter option bbfa1cad3b
include AssetVersion 67fb7fc74e
Quaternions requested review from itzaname 2025-06-22 03:52:54 +00:00
itzaname commented 2025-06-22 06:20:20 +00:00
Owner
Copy Link

Is this OBE like StrafesNET/data-service#30

Is this OBE like https://git.itzana.me/StrafesNET/data-service/pulls/30
Quaternions commented 2025-06-22 06:41:25 +00:00
Author
Owner
Copy Link

I don't know that acronym, but I assume it means something like N/A. I guess the maps service doesn't currently have a gRPC interface so this is indeed no longer applicable.

Edit:
Reference for future quat: OBE is "Overtaken By Events" meaning made irrelevant by other changes

I don't know that acronym, but I assume it means something like N/A. I guess the maps service doesn't currently have a gRPC interface so this is indeed no longer applicable. Edit: Reference for future quat: OBE is "Overtaken By Events" meaning made irrelevant by other changes
Quaternions closed this pull request 2025-06-22 06:41:25 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
itzaname
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CI itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/protobufs#4
Delete Branch "maps-fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?