StrafesNET/strafe-project
7
Fork 4
Code Issues 18 Pull Requests Packages Projects Releases 2 Wiki Activity

Fix infinite loop with intersects when allowing 0s collisions #21

Closed
aidan9382 wants to merge 8 commits from aidan9382/strafe-project:fix-intersect-loop into bug3-real
pull from: aidan9382/strafe-project:fix-intersect-loop
merge into: StrafesNET:bug3-real
Conversation 2 Commits 8 Files Changed 3 +10 -8
aidan9382 commented 2025-11-19 08:44:47 +00:00
Member
Copy Link

The issue that was happening was that when you collide with the intersect, your timer is transitioned to the immediate point of entry, but your velocity isn't constrained, so on the next tick it picks up the same intersect collision at 0s, and this essentially happens on-loop

The issue that was happening was that when you collide with the intersect, your timer is transitioned to the immediate point of entry, but your velocity *isn't* constrained, so on the next tick it picks up the same intersect collision at 0s, and this essentially happens on-loop
aidan9382 added 1 commit 2025-11-19 08:44:48 +00:00
Fix infinite loop with intersects when allowing 0s collisions 55fb6e270a
Quaternions commented 2025-11-19 16:56:17 +00:00
Owner
Copy Link

Wow! I didn't realize I never filtered the collision testing by the existing contacts list, that's a big mistake. I think this is a bigger / separate issue than bug 3 and can be merged into master. I've created a WIP branch that includes this commit. Closing in favour of working on #22

Wow! I didn't realize I never filtered the collision testing by the existing contacts list, that's a big mistake. I think this is a bigger / separate issue than bug 3 and can be merged into master. I've created a WIP branch that includes this commit. Closing in favour of working on #22
Quaternions closed this pull request 2025-11-19 16:56:17 +00:00
aidan9382 commented 2025-11-19 17:08:43 +00:00
Author
Member
Copy Link

I mostly made it a bug3 merge since otherwise any bug3->master merge would have really annoying conflict resolving and I've gotten sick of git recently

I mostly made it a bug3 merge since otherwise any bug3->master merge would have really annoying conflict resolving and I've gotten sick of git recently

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
enhancement
map-convert
physics-bug
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AxisAngles CI itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/strafe-project#21
Delete Branch "aidan9382/strafe-project:fix-intersect-loop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?