StrafesNET/strafe-project
7
Fork 4
Code Issues 18 Pull Requests Packages Projects Releases 2 Wiki Activity

Gracefully handle 0 acceleration for walking targets #19

Merged
Quaternions merged 1 commits from aidan9382/strafe-project:walk-0-accel into master 2025-11-18 19:47:05 +00:00
Conversation 2 Commits 1 Files Changed 1 +4 -1
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
engine/physics/src/physics.rs
View File

@@ -100,7 +100,6 @@ enum TransientAcceleration{
time:Time,
},
//walk target will never be reached
#[expect(dead_code)]
Unreachable{
acceleration:Planar64Vec3,
}
@@ -116,6 +115,10 @@ impl TransientAcceleration{
fn with_target_diff(target_diff:Planar64Vec3,accel:Planar64,time:Time)->Self{
if target_diff==vec3::ZERO{
TransientAcceleration::Reached
}else if accel==Planar64::ZERO{
aidan9382 marked this conversation as resolved Outdated
Quaternions commented 2025-11-18 19:37:44 +00:00
Outdated
Review
Copy Link

Please use Planar64::ZERO instead of 0, 0 is implicitly converted to Planar64 for the comparison at run time.

Please use Planar64::ZERO instead of 0, 0 is implicitly converted to Planar64 for the comparison at run time.
aidan9382 commented 2025-11-18 19:42:38 +00:00
Outdated
Review
Copy Link

my brain just assumed it was a static number for some reason

my brain just assumed it was a static number for some reason
TransientAcceleration::Unreachable{
acceleration:vec3::ZERO
}
}else{
//normal friction acceleration is clippedAcceleration.dot(normal)*friction
TransientAcceleration::Reachable{