debug

Cargo.lock

@@ -3892,8 +3892,6 @@ dependencies = [
  "glam",
  "id",
  "strafesnet_common",
- "strafesnet_physics",
- "strafesnet_rbx_loader",
  "strafesnet_session",
  "strafesnet_settings",
  "wgpu",
@@ -3906,6 +3904,7 @@ dependencies = [
  "arrayvec",
  "glam",
  "id",
+ "mlua",
  "strafesnet_common",
 ]
 

engine/graphics/Cargo.toml

@@ -9,8 +9,6 @@ ddsfile = "0.5.1"
 glam = "0.30.0"
 id = { version = "0.1.0", registry = "strafesnet" }
 strafesnet_common = { path = "../../lib/common", registry = "strafesnet" }
-strafesnet_physics = { path = "../physics", registry = "strafesnet" }
-strafesnet_rbx_loader = { path = "../../lib/rbx_loader", registry = "strafesnet" }
 strafesnet_session = { path = "../session", registry = "strafesnet" }
 strafesnet_settings = { path = "../settings", registry = "strafesnet" }
 wgpu = "28.0.0"

engine/graphics/src/graphics.rs

@@ -5,20 +5,10 @@ use strafesnet_settings::settings;
 use strafesnet_session::session;
 use strafesnet_common::model::{self, ColorId, NormalId, PolygonIter, PositionId, RenderConfigId, TextureCoordinateId, VertexId};
 use wgpu::{util::DeviceExt,AstcBlock,AstcChannel};
-use crate::model::{self as model_graphics,IndexedGraphicsMeshOwnedRenderConfig,IndexedGraphicsMeshOwnedRenderConfigId,GraphicsMeshOwnedRenderConfig,GraphicsModelColor4,GraphicsModelOwned,GraphicsVertex,DebugGraphicsVertex};
+use crate::model::{self as model_graphics,IndexedGraphicsMeshOwnedRenderConfig,IndexedGraphicsMeshOwnedRenderConfigId,GraphicsMeshOwnedRenderConfig,GraphicsModelColor4,GraphicsModelOwned,GraphicsVertex};
 
 pub fn required_limits()->wgpu::Limits{
-	let mut limits=wgpu::Limits::default();
-	limits.max_task_invocations_per_dimension=1;
-	limits.max_task_invocations_per_workgroup=1;
-	limits.max_mesh_invocations_per_dimension=1;
-	limits.max_mesh_invocations_per_workgroup=1;
-	limits.max_task_mesh_workgroup_total_count=1;
-	limits.max_task_mesh_workgroups_per_dimension=1;
-	limits.max_task_payload_size=4;
-	limits.max_mesh_output_vertices=2*(3+2+4+8);
-	limits.max_mesh_output_primitives=2*(1+2+4+8)+2;
-	limits
+	wgpu::Limits::default()
 }
 
 struct Indices{
@@ -46,135 +36,12 @@ struct GraphicsModel{
 	instance_count:u32,
 }
 
-struct DebugGraphicsSubmesh{
-	verts:Vec<strafesnet_physics::model::MeshVertId>,
-	edges:Vec<[strafesnet_physics::model::MeshVertId;2]>,
-	faces:Vec<Indices>,
-}
-struct DebugGraphicsMesh{
-	vertices:Vec<DebugGraphicsVertex>,
-	indices:Indices,
-	submeshes:Vec<DebugGraphicsSubmesh>,
-	vertex_buf:wgpu::Buffer,
-}
-impl DebugGraphicsMesh{
-	fn new(device:&wgpu::Device,mesh:&model::Mesh)->Self{
-		let vertices:Vec<DebugGraphicsVertex>=mesh.unique_pos.iter().copied().map(|pos|{
-			DebugGraphicsVertex{
-				pos:pos.to_array().map(Into::into),
-			}
-		}).collect();
-		let vertex_buf=device.create_buffer_init(&wgpu::util::BufferInitDescriptor{
-			label:Some("Vertex"),
-			contents:bytemuck::cast_slice(&vertices),
-			usage:wgpu::BufferUsages::VERTEX,
-		});
-
-		macro_rules! indices{
-			($indices:expr)=>{
-				if (u32::MAX as usize)<vertices.len(){
-					panic!("Model has too many vertices!");
-				}else if (u16::MAX as usize)<vertices.len(){
-					Indices::new(device,&$indices.into_iter().map(|vertex_idx|vertex_idx.get() as u32).collect(),wgpu::IndexFormat::Uint32)
-				}else{
-					Indices::new(device,&$indices.into_iter().map(|vertex_idx|vertex_idx.get() as u16).collect(),wgpu::IndexFormat::Uint16)
-				}
-			};
-		}
-
-
-		let mut all_indices=Vec::new();
-
-		let submeshes=if let Ok(physics_mesh)=strafesnet_physics::model::PhysicsMesh::try_from(mesh){
-			physics_mesh.submesh_views().into_iter().map(|submesh_view|DebugGraphicsSubmesh{
-				verts:submesh_view.verts().to_owned(),
-				edges:submesh_view.edge_vert_ids_iter().collect(),
-				faces:submesh_view.face_vert_ids_iter().map(|face_verts|{
-					// triangulate
-					let mut indices=Vec::new();
-					let mut poly_vertices=face_verts.into_iter();
-					if let (Some(a),Some(mut b))=(poly_vertices.next(),poly_vertices.next()){
-						for c in poly_vertices{
-							indices.extend([a,b,c]);
-							all_indices.extend([a,b,c]);
-							b=c;
-						}
-					}
-					indices!(indices)
-				}).collect(),
-			}).collect()
-		}else{
-			//idc
-			Vec::new()
-		};
-
-		let indices=indices!(all_indices);
-
-		DebugGraphicsMesh{
-			vertices,
-			indices,
-			submeshes,
-			vertex_buf,
-		}
-	}
-}
-
-struct DebugGraphicsModel{
-	debug_mesh_id:u32,
-	bind_group:wgpu::BindGroup,
-	// 32 bytes used to tell the mesh shader where to draw
-	// Vert: [vec4,_]
-	// Edge: [vec4,vec4]
-	debug_buf:wgpu::Buffer,
-	model_buf:wgpu::Buffer,
-}
-impl DebugGraphicsModel{
-	fn new(device:&wgpu::Device,layout:&wgpu::BindGroupLayout,model:&model::Model,model_id:usize,color:glam::Vec4)->Self{
-		let model_uniforms=get_instances_buffer_data(&[GraphicsModelOwned{
-			transform:model.transform.into(),
-			normal_transform:glam::Mat3::from_cols_array_2d(&model.transform.matrix3.to_array().map(|row|row.map(Into::into))).inverse().transpose(),
-			color:GraphicsModelColor4::new(color),
-		}]);
-		let model_buf=device.create_buffer_init(&wgpu::util::BufferInitDescriptor{
-			label:Some(format!("Debug Model{} Buf",model_id).as_str()),
-			contents:bytemuck::cast_slice(&model_uniforms),
-			usage:wgpu::BufferUsages::UNIFORM|wgpu::BufferUsages::COPY_DST,
-		});
-		let debug_buf=device.create_buffer_init(&wgpu::util::BufferInitDescriptor{
-			label:Some(format!("Debug Model{} EV Buf",model_id).as_str()),
-			contents:bytemuck::cast_slice(&[0u8;32]),
-			usage:wgpu::BufferUsages::UNIFORM|wgpu::BufferUsages::COPY_DST,
-		});
-		let bind_group=device.create_bind_group(&wgpu::BindGroupDescriptor{
-			layout,
-			entries:&[
-				wgpu::BindGroupEntry{
-					binding:0,
-					resource:model_buf.as_entire_binding(),
-				},
-				wgpu::BindGroupEntry{
-					binding:1,
-					resource:debug_buf.as_entire_binding(),
-				},
-			],
-			label:Some(format!("Debug Model{} Bind Group",model_id).as_str()),
-		});
-		DebugGraphicsModel{
-			debug_mesh_id:model.mesh.get(),
-			bind_group,
-			debug_buf,
-			model_buf,
-		}
-	}
-}
-
 struct GraphicsSamplers{
 	repeat:wgpu::Sampler,
 }
 
 struct GraphicsBindGroupLayouts{
 	model:wgpu::BindGroupLayout,
-	debug_model:wgpu::BindGroupLayout,
 }
 
 struct GraphicsBindGroups{
@@ -185,9 +52,6 @@ struct GraphicsBindGroups{
 struct GraphicsPipelines{
 	skybox:wgpu::RenderPipeline,
 	model:wgpu::RenderPipeline,
-	debug:wgpu::RenderPipeline,
-	debug_edge:wgpu::RenderPipeline,
-	debug_vert:wgpu::RenderPipeline,
 }
 
 struct GraphicsCamera{
@@ -268,10 +132,6 @@ pub struct GraphicsState{
 	camera_buf:wgpu::Buffer,
 	temp_squid_texture_view:wgpu::TextureView,
 	models:Vec<GraphicsModel>,
-	debug_meshes:Vec<DebugGraphicsMesh>,
-	debug_models:Vec<DebugGraphicsModel>,
-	hitbox_mesh:DebugGraphicsMesh,
-	hitbox_model:DebugGraphicsModel,
 	depth_view:wgpu::TextureView,
 	staging_belt:wgpu::util::StagingBelt,
 }
@@ -306,16 +166,6 @@ impl GraphicsState{
 		self.camera.fov=user_settings.calculate_fov(1.0,&self.camera.screen_size).as_vec2();
 	}
 	pub fn generate_models(&mut self,device:&wgpu::Device,queue:&wgpu::Queue,map:&map::CompleteMap){
-		//generate debug meshes, each debug model refers to one
-		self.debug_meshes=map.meshes.iter().map(|mesh|
-			DebugGraphicsMesh::new(device,mesh)
-		).collect();
-
-		//generate debug models, only one will be rendered at a time
-		self.debug_models=map.models.iter().enumerate().map(|(model_id,model)|{
-			DebugGraphicsModel::new(device,&self.bind_group_layouts.debug_model,model,model_id,glam::vec4(1.0,0.0,0.0,0.2))
-		}).collect();
-
 		//generate texture view per texture
 		let texture_views:HashMap<model::TextureId,wgpu::TextureView>=map.textures.iter().enumerate().filter_map(|(texture_id,texture_data)|{
 			let texture_id=model::TextureId::new(texture_id as u32);
@@ -696,7 +546,7 @@ impl GraphicsState{
 			entries:&[
 				wgpu::BindGroupLayoutEntry{
 					binding:0,
-					visibility:wgpu::ShaderStages::VERTEX|wgpu::ShaderStages::MESH,
+					visibility:wgpu::ShaderStages::VERTEX,
 					ty:wgpu::BindingType::Buffer{
 						ty:wgpu::BufferBindingType::Uniform,
 						has_dynamic_offset:false,
@@ -758,31 +608,6 @@ impl GraphicsState{
 				},
 			],
 		});
-		let debug_model_bind_group_layout=device.create_bind_group_layout(&wgpu::BindGroupLayoutDescriptor{
-			label:Some("Debug Model Bind Group Layout"),
-			entries:&[
-				wgpu::BindGroupLayoutEntry{
-					binding:0,
-					visibility:wgpu::ShaderStages::VERTEX_FRAGMENT|wgpu::ShaderStages::MESH,
-					ty:wgpu::BindingType::Buffer{
-						ty:wgpu::BufferBindingType::Uniform,
-						has_dynamic_offset:false,
-						min_binding_size:None,
-					},
-					count:None,
-				},
-				wgpu::BindGroupLayoutEntry{
-					binding:1,
-					visibility:wgpu::ShaderStages::MESH,
-					ty:wgpu::BindingType::Buffer{
-						ty:wgpu::BufferBindingType::Uniform,
-						has_dynamic_offset:false,
-						min_binding_size:None,
-					},
-					count:None,
-				},
-			],
-		});
 
 		let clamp_sampler=device.create_sampler(&wgpu::SamplerDescriptor{
 			label:Some("Clamp Sampler"),
@@ -931,14 +756,6 @@ impl GraphicsState{
 			],
 			immediate_size:0,
 		});
-		let debug_model_pipeline_layout=device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor{
-				label:None,
-				bind_group_layouts:&[
-					&camera_bind_group_layout,
-					&debug_model_bind_group_layout,
-				],
-				immediate_size:0,
-			});
 		let sky_pipeline_layout=device.create_pipeline_layout(&wgpu::PipelineLayoutDescriptor{
 			label:None,
 			bind_group_layouts:&[
@@ -1014,92 +831,6 @@ impl GraphicsState{
 			multiview_mask:None,
 			cache:None,
 		});
-		let debug_model_pipeline=device.create_render_pipeline(&wgpu::RenderPipelineDescriptor{
-			label:Some("Debug Pipeline"),
-			layout:Some(&debug_model_pipeline_layout),
-			vertex:wgpu::VertexState{
-				module:&shader,
-				entry_point:Some("vs_debug"),
-				buffers:&[wgpu::VertexBufferLayout{
-					array_stride:size_of::<DebugGraphicsVertex>() as wgpu::BufferAddress,
-					step_mode:wgpu::VertexStepMode::Vertex,
-					attributes:&wgpu::vertex_attr_array![0=>Float32x3],
-				}],
-				compilation_options:wgpu::PipelineCompilationOptions::default(),
-			},
-			fragment:Some(wgpu::FragmentState{
-				module:&shader,
-				entry_point:Some("fs_debug"),
-				targets:&[Some(wgpu::ColorTargetState{
-					format:config.view_formats[0],
-					blend:Some(wgpu::BlendState::ALPHA_BLENDING),
-					write_mask:wgpu::ColorWrites::default(),
-				})],
-				compilation_options:wgpu::PipelineCompilationOptions::default(),
-			}),
-			primitive:wgpu::PrimitiveState{
-				topology:wgpu::PrimitiveTopology::TriangleList,
-				front_face:wgpu::FrontFace::Cw,
-				cull_mode:Some(wgpu::Face::Front),
-				..Default::default()
-			},
-			depth_stencil:Some(wgpu::DepthStencilState{
-				format:Self::DEPTH_FORMAT,
-				depth_write_enabled:true,
-				depth_compare:wgpu::CompareFunction::LessEqual,
-				stencil:wgpu::StencilState::default(),
-				bias:wgpu::DepthBiasState::default(),
-			}),
-			multisample:wgpu::MultisampleState::default(),
-			multiview_mask:None,
-			cache:None,
-		});
-		let mut debug_model_pipeline_ms=wgpu::MeshPipelineDescriptor{
-			label:None,//filled in below
-			layout:Some(&debug_model_pipeline_layout),
-			task:Some(wgpu::TaskState{
-				module:&shader,
-				entry_point:Some("ts_main"),
-				compilation_options:wgpu::PipelineCompilationOptions::default(),
-			}),
-			mesh:wgpu::MeshState{
-				module:&shader,
-				entry_point:None,//filled in below
-				compilation_options:wgpu::PipelineCompilationOptions::default(),
-			},
-			fragment:Some(wgpu::FragmentState{
-				module:&shader,
-				entry_point:Some("fs_debug"),
-				targets:&[Some(wgpu::ColorTargetState{
-					format:config.view_formats[0],
-					blend:Some(wgpu::BlendState::ALPHA_BLENDING),
-					write_mask:wgpu::ColorWrites::default(),
-				})],
-				compilation_options:wgpu::PipelineCompilationOptions::default(),
-			}),
-			primitive:wgpu::PrimitiveState{
-				topology:wgpu::PrimitiveTopology::TriangleList,
-				front_face:wgpu::FrontFace::Cw,
-				cull_mode:None,
-				..Default::default()
-			},
-			depth_stencil:Some(wgpu::DepthStencilState{
-				format:Self::DEPTH_FORMAT,
-				depth_write_enabled:true,
-				depth_compare:wgpu::CompareFunction::Always,
-				stencil:wgpu::StencilState::default(),
-				bias:wgpu::DepthBiasState::default(),
-			}),
-			multisample:wgpu::MultisampleState::default(),
-			multiview:None,
-			cache:None,
-		};
-		debug_model_pipeline_ms.label=Some("Debug Vert Pipeline");
-		debug_model_pipeline_ms.mesh.entry_point=Some("ms_debug_vert");
-		let debug_model_pipeline_vert=device.create_mesh_pipeline(&debug_model_pipeline_ms);
-		debug_model_pipeline_ms.label=Some("Debug Edge Pipeline");
-		debug_model_pipeline_ms.mesh.entry_point=Some("ms_debug_edge");
-		let debug_model_pipeline_edge=device.create_mesh_pipeline(&debug_model_pipeline_ms);
 
 		let camera=GraphicsCamera::default();
 		let camera_uniforms=camera.to_uniform_data(glam::Vec3::ZERO,glam::Vec2::ZERO);
@@ -1136,23 +867,10 @@ impl GraphicsState{
 
 		let depth_view=Self::create_depth_texture(config,device);
 
-		// WHIP UP A CUBE
-		let cube_face_description=strafesnet_rbx_loader::primitives::CubeFaceDescription::new(Default::default(),RenderConfigId::new(0));
-		let hitbox_mesh=DebugGraphicsMesh::new(device,&strafesnet_rbx_loader::primitives::unit_cube(cube_face_description));
-		let hitbox_model=DebugGraphicsModel::new(device,&debug_model_bind_group_layout,&model::Model{
-			mesh:model::MeshId::new(u32::MAX),
-			attributes:strafesnet_common::gameplay_attributes::CollisionAttributesId::new(0),
-			color:glam::Vec4::new(0.0,0.0,1.0,0.2),
-			transform:strafesnet_common::integer::Planar64Affine3::IDENTITY,
-		},u32::MAX as usize,glam::vec4(0.0,1.0,0.0,0.2));
-
 		Self{
 			pipelines:GraphicsPipelines{
 				skybox:sky_pipeline,
-				model:model_pipeline,
-				debug:debug_model_pipeline,
-				debug_edge:debug_model_pipeline_edge,
-				debug_vert:debug_model_pipeline_vert,
+				model:model_pipeline
 			},
 			bind_groups:GraphicsBindGroups{
 				camera:camera_bind_group,
@@ -1161,16 +879,9 @@ impl GraphicsState{
 			camera,
 			camera_buf,
 			models:Vec::new(),
-			debug_meshes:Vec::new(),
-			debug_models:Vec::new(),
-			hitbox_mesh,
-			hitbox_model,
 			depth_view,
 			staging_belt:wgpu::util::StagingBelt::new(device.clone(),0x100),
-			bind_group_layouts:GraphicsBindGroupLayouts{
-				model:model_bind_group_layout,
-				debug_model:debug_model_bind_group_layout,
-			},
+			bind_group_layouts:GraphicsBindGroupLayouts{model:model_bind_group_layout},
 			samplers:GraphicsSamplers{repeat:repeat_sampler},
 			temp_squid_texture_view:squid_texture_view,
 		}
@@ -1224,66 +935,6 @@ impl GraphicsState{
 				.copy_from_slice(bytemuck::cast_slice(&model_uniforms));
 		}
 		*/
-
-		// update hitbox mesh transform
-		if let Some(debug_hitbox_position)=frame_state.debug_hitbox_position{
-			let model_uniforms=get_instances_buffer_data(&[GraphicsModelOwned{
-				transform:debug_hitbox_position.into(),
-				normal_transform:glam::Mat3::IDENTITY,
-				color:GraphicsModelColor4::new(glam::vec4(1.0,0.0,0.0,0.2)),
-			}]);
-			let debug_slice=bytemuck::cast_slice(&model_uniforms);
-			self.staging_belt.write_buffer(
-				&mut encoder,
-				&self.hitbox_model.model_buf,
-				0,
-				wgpu::BufferSize::new(debug_slice.len() as wgpu::BufferAddress).unwrap(),
-			).copy_from_slice(debug_slice);
-		}
-
-		// upload the edge or vertex for the mesh shader to highlight
-		if let Some(hit)=&frame_state.hit{
-			if let Some(closest_fev)=&hit.closest_fev{
-				let model_id:model::ModelId=hit.convex_mesh_id.model_id.into();
-				if let Some(model)=self.debug_models.get(model_id.get() as usize){
-					let mesh=&self.debug_meshes[model.debug_mesh_id as usize];
-					match closest_fev{
-						strafesnet_physics::model::FEV::Face(_face)=>{
-							// face is rendered normally
-						},
-						strafesnet_physics::model::FEV::Edge(edge)=>{
-							let [v0_id,v1_id]=mesh.submeshes[hit.convex_mesh_id.submesh_id.get() as usize].edges[edge.get() as usize];
-							let v0_pos=mesh.vertices[v0_id.get() as usize].pos;
-							let v1_pos=mesh.vertices[v1_id.get() as usize].pos;
-							let debug_data=[glam::Vec3A::from_array(v0_pos).extend(1.0).to_array(),glam::Vec3A::from_array(v1_pos).extend(1.0).to_array()];
-							let debug_slice=bytemuck::cast_slice(&debug_data);
-							self.staging_belt
-								.write_buffer(
-									&mut encoder,
-									&model.debug_buf,
-									0,
-									wgpu::BufferSize::new(debug_slice.len() as wgpu::BufferAddress).unwrap(),
-								)
-								.copy_from_slice(debug_slice);
-						},
-						strafesnet_physics::model::FEV::Vert(vert)=>{
-							let vert_id=mesh.submeshes[hit.convex_mesh_id.submesh_id.get() as usize].verts[vert.get() as usize].get();
-							let pos=mesh.vertices[vert_id as usize].pos;
-							let debug_data=[glam::Vec3A::from_array(pos).extend(1.0).to_array()];
-							let debug_slice=bytemuck::cast_slice(&debug_data);
-							self.staging_belt
-								.write_buffer(
-									&mut encoder,
-									&model.debug_buf,
-									0,
-									wgpu::BufferSize::new(debug_slice.len() as wgpu::BufferAddress).unwrap(),
-								)
-								.copy_from_slice(debug_slice);
-						},
-					}
-				}
-			}
-		}
 		self.staging_belt.finish();
 
 		{
@@ -1319,7 +970,6 @@ impl GraphicsState{
 			rpass.set_bind_group(0,&self.bind_groups.camera,&[]);
 			rpass.set_bind_group(1,&self.bind_groups.skybox_texture,&[]);
 
-			// Draw all models.
 			rpass.set_pipeline(&self.pipelines.model);
 			for model in &self.models{
 				rpass.set_bind_group(2,&model.bind_group,&[]);
@@ -1331,46 +981,6 @@ impl GraphicsState{
 
 			rpass.set_pipeline(&self.pipelines.skybox);
 			rpass.draw(0..3,0..1);
-
-			// render a single debug_model in red
-			if let Some(hit)=&frame_state.hit{
-				if let Some(closest_fev)=&hit.closest_fev{
-					let model_id:model::ModelId=hit.convex_mesh_id.model_id.into();
-					if let Some(model)=self.debug_models.get(model_id.get() as usize){
-						let mesh=&self.debug_meshes[model.debug_mesh_id as usize];
-						rpass.set_bind_group(1,&model.bind_group,&[]);
-						rpass.set_vertex_buffer(0,mesh.vertex_buf.slice(..));
-						match closest_fev{
-							strafesnet_physics::model::FEV::Face(face)=>{
-								rpass.set_pipeline(&self.pipelines.debug);
-								let indices=&mesh.submeshes[hit.convex_mesh_id.submesh_id.get() as usize].faces[face.get() as usize];
-								rpass.set_index_buffer(indices.buf.slice(..),indices.format);
-								//TODO: loop over triangle strips
-								rpass.draw_indexed(0..indices.count,0,0..1);
-							},
-							strafesnet_physics::model::FEV::Edge(_edge)=>{
-								rpass.set_pipeline(&self.pipelines.debug_edge);
-								// the data has already been primed by the staging belt
-								rpass.draw_mesh_tasks(1, 1, 1);
-							},
-							strafesnet_physics::model::FEV::Vert(_vert)=>{
-								rpass.set_pipeline(&self.pipelines.debug_vert);
-								// the data has already been primed by the staging belt
-								rpass.draw_mesh_tasks(1, 1, 1);
-							},
-						}
-					}
-				}
-			}
-
-			if frame_state.debug_hitbox_position.is_some(){
-				rpass.set_bind_group(1,&self.hitbox_model.bind_group,&[]);
-				rpass.set_vertex_buffer(0,self.hitbox_mesh.vertex_buf.slice(..));
-				rpass.set_pipeline(&self.pipelines.debug);
-				rpass.set_index_buffer(self.hitbox_mesh.indices.buf.slice(..),self.hitbox_mesh.indices.format);
-				//TODO: loop over triangle strips
-				rpass.draw_indexed(0..self.hitbox_mesh.indices.count,0,0..1);
-			}
 		}
 
 		queue.submit(std::iter::once(encoder.finish()));

engine/graphics/src/model.rs

@@ -8,11 +8,6 @@ pub struct GraphicsVertex{
 	pub normal:[f32;3],
 	pub color:[f32;4],
 }
-#[derive(Clone,Copy,Pod,Zeroable)]
-#[repr(C)]
-pub struct DebugGraphicsVertex{
-	pub pos:[f32;3],
-}
 #[derive(Clone,Copy,id::Id)]
 pub struct IndexedGraphicsMeshOwnedRenderConfigId(u32);
 pub struct IndexedGraphicsMeshOwnedRenderConfig{

engine/physics/Cargo.toml

@@ -7,6 +7,7 @@ edition = "2024"
 arrayvec = "0.7.6"
 glam = "0.30.0"
 id = { version = "0.1.0", registry = "strafesnet" }
+mlua = { version = "0.11.5", features = ["luau"] }
 strafesnet_common = { path = "../../lib/common", registry = "strafesnet" }
 
 [lints]

engine/physics/src/face_crawler.rs

@@ -15,12 +15,6 @@ pub enum CrawlResult<M:MeshQuery>{
 	Hit(M::Face,GigaTime),
 }
 impl<M:MeshQuery> CrawlResult<M>{
-	pub fn fev(self)->FEV<M>{
-		match self{
-			CrawlResult::Miss(fev)=>fev,
-			CrawlResult::Hit(face,_)=>FEV::Face(face),
-		}
-	}
 	pub fn hit(self)->Option<(M::Face,GigaTime)>{
 		match self{
 			CrawlResult::Miss(_)=>None,

engine/physics/src/lib.rs

@@ -1,8 +1,9 @@
 mod body;
 mod face_crawler;
-pub mod model;
+mod model;
 mod push_solve;
 mod minimum_difference;
+mod minimum_difference_lua;
 
 pub mod physics;
 

engine/physics/src/minimum_difference.rs

@@ -10,7 +10,7 @@ use crate::model::{MinkowskiMesh,MinkowskiVert};
 // written by Trey Reynolds in 2021
 
 type Simplex<const N:usize,Vert>=[Vert;N];
-#[derive(Clone,Copy)]
+#[derive(Clone,Copy,Debug)]
 enum Simplex1_3<Vert>{
 	Simplex1(Simplex<1,Vert>),
 	Simplex2(Simplex<2,Vert>),
@@ -136,12 +136,15 @@ fn reduce1<M:MeshQuery>(
 	mesh:&M,
 	point:Planar64Vec3,
 )->Reduced<M::Vert>{
+	println!("reduce1");
 	// --debug.profilebegin("reduceSimplex0")
 	// local a = a1 - a0
 	let p0=mesh.vert(v0);
 
+	println!("p0={p0}");
 	// local p = -a
 	let p=-(p0+point);
+	println!("p={p}");
 
 	// local direction = p
 	let mut dir=p;
@@ -165,6 +168,7 @@ fn reduce2<M:MeshQuery>(
 	mesh:&M,
 	point:Planar64Vec3,
 )->Reduced<M::Vert>{
+	println!("reduce2");
 	// --debug.profilebegin("reduceSimplex1")
 	// local a = a1 - a0
 	// local b = b1 - b0
@@ -222,6 +226,7 @@ fn reduce3<M:MeshQuery>(
 	mesh:&M,
 	point:Planar64Vec3,
 )->Reduced<M::Vert>{
+	println!("reduce3");
 	// --debug.profilebegin("reduceSimplex2")
 	// local a = a1 - a0
 	// local b = b1 - b0
@@ -331,6 +336,7 @@ fn reduce4<M:MeshQuery>(
 	mesh:&M,
 	point:Planar64Vec3,
 )->Reduce<M::Vert>{
+	println!("reduce4");
 	// --debug.profilebegin("reduceSimplex3")
 	// local a = a1 - a0
 	// local b = b1 - b0
@@ -725,11 +731,21 @@ fn crawl_to_closest_fev<'a>(mesh:&MinkowskiMesh<'a>,simplex:Simplex<3,MinkowskiV
 }
 
 pub fn closest_fev_not_inside<'a>(mesh:&MinkowskiMesh<'a>,point:Planar64Vec3)->Option<FEV<MinkowskiMesh<'a>>>{
+	println!("=== LUA ===");
+	let (hits,_details)=crate::minimum_difference_lua::minimum_difference_details(mesh,point).unwrap();
+	println!("=== RUST ===");
+	let closest_fev_not_inside=closest_fev_not_inside_inner(mesh,point);
+	assert_eq!(hits,closest_fev_not_inside.is_none(),"algorithms disagree");
+	closest_fev_not_inside
+}
+
+fn closest_fev_not_inside_inner<'a>(mesh:&MinkowskiMesh<'a>,point:Planar64Vec3)->Option<FEV<MinkowskiMesh<'a>>>{
 	const ENABLE_FAST_FAIL:bool=false;
 	// TODO: remove mesh negation
 	minimum_difference::<ENABLE_FAST_FAIL,_,_>(&-mesh,point,
 		// on_exact
 		|is_intersecting,simplex|{
+			println!("on_exact is_intersecting={is_intersecting} simplex={simplex:?}");
 			if is_intersecting{
 				return None;
 			}
@@ -803,6 +819,7 @@ fn minimum_difference<const ENABLE_FAST_FAIL:bool,T,M:MeshQuery>(
 	if initial_axis==vec3::zero(){
 		initial_axis=choose_any_direction();
 	}
+	println!("initial_axis={initial_axis}");
 	let last_point=mesh.farthest_vert(-initial_axis);
 	// this represents the 'a' value in the commented code
 	let mut last_pos=mesh.vert(last_point);
@@ -811,6 +828,8 @@ fn minimum_difference<const ENABLE_FAST_FAIL:bool,T,M:MeshQuery>(
 	// exitRadius = testIntersection and 0 or exitRadius or 1/0
 	// for _ = 1, 100 do
 	loop{
+		println!("direction={direction}");
+
 		// new_point_p = queryP(-direction)
 		// new_point_q = queryQ(direction)
 		// local next_point = new_point_q - new_point_p
@@ -818,7 +837,11 @@ fn minimum_difference<const ENABLE_FAST_FAIL:bool,T,M:MeshQuery>(
 		let next_pos=mesh.vert(next_point);
 
 		// if -direction:Dot(next_point) > (exitRadius + radiusP + radiusQ)*direction.magnitude then
-		if ENABLE_FAST_FAIL&&direction.dot(next_pos+point).is_negative(){
+		let d=direction.dot(next_pos+point);
+		let fast_fail=d.is_negative();
+		println!("ENABLE_FAST_FAIL={ENABLE_FAST_FAIL} fast_fail={fast_fail} next_point={} dot={d}",next_pos+point);
+		if ENABLE_FAST_FAIL&&fast_fail{
+			println!("on_fast_fail");
 			return on_fast_fail();
 		}
 
@@ -827,8 +850,11 @@ fn minimum_difference<const ENABLE_FAST_FAIL:bool,T,M:MeshQuery>(
 		// if
 		// 	direction:Dot(next_point - a) <= 0 or
 		// 	absDet(next_point, a, b, c) < 1e-6
-		if !direction.dot(next_pos-last_pos).is_positive()
-		||simplex_big.det_is_zero(mesh){
+		let cond1=!direction.dot(next_pos-last_pos).is_positive();
+		let cond2=simplex_big.det_is_zero(mesh);
+		println!("cond1={cond1} cond2={cond2}");
+		if cond1||cond2{
+			println!("on_exact");
 			// Found enough information to compute the exact closest point.
 			// local norm = direction.unit
 			// local dist = a:Dot(norm)
@@ -841,6 +867,7 @@ fn minimum_difference<const ENABLE_FAST_FAIL:bool,T,M:MeshQuery>(
 		match simplex_big.reduce(mesh,point){
 			// if a and b and c and d then
 			Reduce::Escape(simplex)=>{
+				println!("on_escape");
 				// Enough information to conclude that the meshes are intersecting.
 				// Topology information is computed if needed.
 				return on_escape(simplex);

engine/physics/src/minimum_difference_lua.rs

@@ -0,0 +1,173 @@
+use mlua::{Lua,FromLuaMulti,IntoLuaMulti,Function,Result as LuaResult,Vector};
+use strafesnet_common::integer::{Planar64,Planar64Vec3,FixedFromFloatError};
+
+use crate::model::{MeshQuery,MinkowskiMesh};
+
+pub fn contains_point(
+	mesh:&MinkowskiMesh,
+	point:Planar64Vec3,
+)->LuaResult<bool>{
+	Ok(minimum_difference(mesh,point,true)?.hits)
+}
+pub fn minimum_difference_details(
+	mesh:&MinkowskiMesh,
+	point:Planar64Vec3,
+)->LuaResult<(bool,Option<Details>)>{
+	let md=minimum_difference(mesh,point,false)?;
+	Ok((md.hits,md.details))
+}
+fn p64v3(v:Vector)->Result<Planar64Vec3,FixedFromFloatError>{
+	Ok(Planar64Vec3::new([
+		v.x().try_into()?,
+		v.y().try_into()?,
+		v.z().try_into()?,
+	]))
+}
+fn vec(v:Planar64Vec3)->Vector{
+	Vector::new(v.x.into(),v.y.into(),v.z.into())
+}
+struct MinimumDifference{
+	hits:bool,
+	details:Option<Details>
+}
+pub struct Details{
+	pub distance:Planar64,
+	pub p_pos:Planar64Vec3,
+	pub p_norm:Planar64Vec3,
+	pub q_pos:Planar64Vec3,
+	pub q_norm:Planar64Vec3,
+}
+impl FromLuaMulti for MinimumDifference{
+	fn from_lua_multi(mut values:mlua::MultiValue,_lua:&Lua)->LuaResult<Self>{
+		match values.make_contiguous(){
+			&mut [
+				mlua::Value::Boolean(hits),
+				mlua::Value::Nil,
+				mlua::Value::Nil,
+				mlua::Value::Nil,
+				mlua::Value::Nil,
+				mlua::Value::Nil,
+			]=>Ok(Self{hits,details:None}),
+			&mut [
+				mlua::Value::Boolean(hits),
+				mlua::Value::Number(distance),
+				mlua::Value::Vector(p_pos),
+				mlua::Value::Vector(p_norm),
+				mlua::Value::Vector(q_pos),
+				mlua::Value::Vector(q_norm),
+			]=>Ok(Self{
+				hits,
+				details:Some(Details{
+					distance:distance.try_into().unwrap(),
+					p_pos:p64v3(p_pos).unwrap(),
+					p_norm:p64v3(p_norm).unwrap(),
+					q_pos:p64v3(q_pos).unwrap(),
+					q_norm:p64v3(q_norm).unwrap(),
+				}),
+			}),
+			&mut [
+				mlua::Value::Boolean(hits),
+				mlua::Value::Integer(distance),
+				mlua::Value::Vector(p_pos),
+				mlua::Value::Vector(p_norm),
+				mlua::Value::Vector(q_pos),
+				mlua::Value::Vector(q_norm),
+			]=>Ok(Self{
+				hits,
+				details:Some(Details{
+					distance:distance.into(),
+					p_pos:p64v3(p_pos).unwrap(),
+					p_norm:p64v3(p_norm).unwrap(),
+					q_pos:p64v3(q_pos).unwrap(),
+					q_norm:p64v3(q_norm).unwrap(),
+				}),
+			}),
+			values=>Err(mlua::Error::runtime(format!("Invalid return values: {values:?}"))),
+		}
+	}
+}
+
+struct Args{
+	query_p:Function,
+	radius_p:f64,
+	query_q:Function,
+	radius_q:f64,
+	test_intersection:bool,
+}
+impl Args{
+	fn new(
+		lua:&Lua,
+		mesh:&'static MinkowskiMesh<'static>,
+		point:Planar64Vec3,
+		test_intersection:bool,
+	)->LuaResult<Self>{
+		let radius_p=0.0;
+		let radius_q=0.0;
+		// Query the farthest point on the mesh in the given direction.
+		let query_p=lua.create_function(move|_,dir:Option<Vector>|{
+			let Some(dir)=dir else{
+				return Ok(vec(mesh.mesh0.hint_point()));
+			};
+			let dir=p64v3(dir).unwrap();
+			let vert_id=mesh.mesh0.farthest_vert(dir);
+			let dir=mesh.mesh0.vert(vert_id);
+			Ok(vec(dir))
+		})?;
+		// query_q is different since it includes the test point offset.
+		let query_q=lua.create_function(move|_,dir:Option<Vector>|{
+			let Some(dir)=dir else{
+				return Ok(vec(mesh.mesh1.hint_point()+point));
+			};
+			let dir=p64v3(dir).unwrap();
+			let vert_id=mesh.mesh1.farthest_vert(dir);
+			let dir=mesh.mesh1.vert(vert_id)+point;
+			Ok(vec(dir))
+		})?;
+		Ok(Args{
+			query_p,
+			radius_p,
+			query_q,
+			radius_q,
+			test_intersection,
+		})
+	}
+}
+impl IntoLuaMulti for Args{
+	fn into_lua_multi(self,lua:&Lua)->LuaResult<mlua::MultiValue>{
+		use mlua::IntoLua;
+		Ok(mlua::MultiValue::from_vec(vec![
+			self.query_p.into_lua(lua)?,
+			self.radius_p.into_lua(lua)?,
+			self.query_q.into_lua(lua)?,
+			self.radius_q.into_lua(lua)?,
+			mlua::Value::Nil,
+			self.test_intersection.into_lua(lua)?,
+		]))
+	}
+}
+
+fn minimum_difference(
+	mesh:&MinkowskiMesh,
+	point:Planar64Vec3,
+	test_intersection:bool,
+)->LuaResult<MinimumDifference>{
+	let ctx=init_lua()?;
+	// SAFETY: mesh lifetime must outlive args usages
+	let mesh=unsafe{core::mem::transmute(mesh)};
+	let args=Args::new(&ctx.lua,mesh,point,test_intersection)?;
+	ctx.f.call(args)
+}
+
+struct Ctx{
+	lua:Lua,
+	f:Function,
+}
+fn init_lua()->LuaResult<Ctx>{
+	static SOURCE:std::sync::LazyLock<String>=std::sync::LazyLock::new(||std::fs::read_to_string("/home/quat/strafesnet/strafe-project/Trey-MinimumDifference.lua").unwrap());
+	let lua=Lua::new();
+	lua.sandbox(true)?;
+	let lib_f=lua.load(SOURCE.as_str()).set_name("Trey-MinimumDifference").into_function()?;
+	let lib:mlua::Table=lib_f.call(())?;
+	let f=lib.raw_get("difference")?;
+	Ok(Ctx{lua,f})
+}

engine/physics/src/model.rs

@@ -60,7 +60,7 @@ impl DirectedEdge for SubmeshDirectedEdgeId{
 }
 
 //Vertex <-> Edge <-> Face -> Collide
-#[derive(Debug,Clone)]
+#[derive(Debug)]
 pub enum FEV<M:MeshQuery>{
 	Face(M::Face),
 	Edge(<M::Edge as DirectedEdge>::UndirectedEdge),
@@ -444,24 +444,6 @@ pub struct PhysicsMeshView<'a>{
 	data:&'a PhysicsMeshData,
 	topology:&'a PhysicsMeshTopology,
 }
-impl PhysicsMeshView<'_>{
-	pub fn verts(&self)->&[MeshVertId]{
-		&self.topology.verts
-	}
-	pub fn edge_vert_ids_iter(&self)->impl Iterator<Item=[MeshVertId;2]>+'_{
-		self.topology.edge_topology.iter().map(|edge|{
-			edge.verts.map(|vert_id|self.topology.verts[vert_id.get() as usize])
-		})
-	}
-	pub fn face_vert_ids_iter(&self)->impl Iterator<Item=impl Iterator<Item=MeshVertId>>+'_{
-		self.topology.face_topology.iter().map(|face|{
-			face.edges.iter().map(|edge_id|{
-				let vert_id=self.topology.edge_topology[edge_id.as_undirected().get() as usize].verts[edge_id.parity() as usize];
-				self.topology.verts[vert_id.get() as usize]
-			})
-		})
-	}
-}
 impl MeshQuery for PhysicsMeshView<'_>{
 	type Face=SubmeshFaceId;
 	type Edge=SubmeshDirectedEdgeId;
@@ -544,9 +526,6 @@ impl TransformedMesh<'_>{
 	pub fn verts<'a>(&'a self)->impl Iterator<Item=Vector3<Fixed<2,64>>>+'a{
 		self.view.data.verts.iter().map(|&Vert(pos)|self.transform.vertex.transform_point3(pos))
 	}
-	pub fn faces(&self)->impl Iterator<Item=SubmeshFaceId>{
-		(0..self.view.topology.faces.len() as u32).map(SubmeshFaceId::new)
-	}
 }
 impl MeshQuery for TransformedMesh<'_>{
 	type Face=SubmeshFaceId;
@@ -633,7 +612,7 @@ impl UndirectedEdge for MinkowskiEdge{
 		}
 	}
 }
-#[derive(Clone,Copy,Debug,Eq,PartialEq)]
+#[derive(Clone,Copy,Debug)]
 pub enum MinkowskiDirectedEdge{
 	VertEdge(SubmeshVertId,SubmeshDirectedEdgeId),
 	EdgeVert(SubmeshDirectedEdgeId,SubmeshVertId),
@@ -666,33 +645,8 @@ pub enum MinkowskiFace{
 
 #[derive(Debug)]
 pub struct MinkowskiMesh<'a>{
-	mesh0:TransformedMesh<'a>,
-	mesh1:TransformedMesh<'a>,
-}
-
-impl FEV<MinkowskiMesh<'_>>{
-	pub fn mesh0<'a>(self)->FEV<TransformedMesh<'a>>{
-		match self{
-			FEV::Face(face)=>{
-				match face{
-					MinkowskiFace::VertFace(submesh_vert_id,_)=>FEV::Vert(submesh_vert_id),
-					MinkowskiFace::EdgeEdge(submesh_edge_id,..)=>FEV::Edge(submesh_edge_id),
-					MinkowskiFace::FaceVert(submesh_face_id,_)=>FEV::Face(submesh_face_id),
-				}
-			},
-			FEV::Edge(edge)=>{
-				match edge{
-					MinkowskiEdge::VertEdge(submesh_vert_id,_)=>FEV::Vert(submesh_vert_id),
-					MinkowskiEdge::EdgeVert(submesh_edge_id,_)=>FEV::Edge(submesh_edge_id),
-				}
-			},
-			FEV::Vert(vert)=>{
-				match vert{
-					MinkowskiVert::VertVert(submesh_vert_id,_)=>FEV::Vert(submesh_vert_id),
-				}
-			},
-		}
-	}
+	pub mesh0:TransformedMesh<'a>,
+	pub mesh1:TransformedMesh<'a>,
 }
 
 pub type GigaTime=Ratio<Fixed<4,128>,Fixed<4,128>>;
@@ -717,24 +671,19 @@ impl MinkowskiMesh<'_>{
 		}
 	}
 	pub fn predict_collision_in(&self,relative_body:&Body,range:impl RangeBounds<Time>)->Option<(MinkowskiFace,GigaTime)>{
-		let start_position=match range.start_bound(){
-			Bound::Included(time)=>relative_body.extrapolated_position(*time),
-			Bound::Excluded(time)=>relative_body.extrapolated_position(*time),
-			Bound::Unbounded=>relative_body.position,
-		};
-		let fev=crate::minimum_difference::closest_fev_not_inside(self,start_position)?;
+		let fev=crate::minimum_difference::closest_fev_not_inside(self,relative_body.position)?;
 		//continue forwards along the body parabola
 		fev.crawl(self,relative_body,range.start_bound(),range.end_bound()).hit()
 	}
 	pub fn predict_collision_out(&self,relative_body:&Body,range:impl RangeBounds<Time>)->Option<(MinkowskiFace,GigaTime)>{
 		let (lower_bound,upper_bound)=(range.start_bound(),range.end_bound());
 		// TODO: handle unbounded collision using infinity fev
-		let start_position=match upper_bound{
-			Bound::Included(time)=>relative_body.extrapolated_position(*time),
-			Bound::Excluded(time)=>relative_body.extrapolated_position(*time),
-			Bound::Unbounded=>relative_body.position,
+		let time=match upper_bound{
+			Bound::Included(&time)=>time,
+			Bound::Excluded(&time)=>time,
+			Bound::Unbounded=>unimplemented!("unbounded collision out"),
 		};
-		let fev=crate::minimum_difference::closest_fev_not_inside(self,start_position)?;
+		let fev=crate::minimum_difference::closest_fev_not_inside(self,relative_body.extrapolated_position(time))?;
 		// swap and negate bounds to do a time inversion
 		let (lower_bound,upper_bound)=(upper_bound.map(|&t|-t),lower_bound.map(|&t|-t));
 		let infinity_body=-relative_body;

engine/physics/src/physics.rs

@@ -1,5 +1,4 @@
 use std::collections::{HashMap,HashSet};
-use crate::model::DirectedEdge;
 use crate::model::{self as model_physics,PhysicsMesh,PhysicsMeshTransform,TransformedMesh,MeshQuery,PhysicsMeshId,PhysicsSubmeshId};
 use strafesnet_common::bvh;
 use strafesnet_common::map;
@@ -29,7 +28,6 @@ pub enum InternalInstruction{
 	CollisionStart(Collision,model_physics::GigaTime),
 	CollisionEnd(Collision,model_physics::GigaTime),
 	StrafeTick,
-	// TODO: add GigaTime to ReachWalkTargetVelocity
 	ReachWalkTargetVelocity,
 	// Water,
 }
@@ -288,8 +286,7 @@ impl PhysicsCamera{
 		.clamp(Self::ANGLE_PITCH_LOWER_LIMIT,Self::ANGLE_PITCH_UPPER_LIMIT);
 		mat3::from_rotation_yx(ax,ay)
 	}
-	#[inline]
-	pub fn rotation(&self)->Planar64Mat3{
+	fn rotation(&self)->Planar64Mat3{
 		self.get_rotation(self.clamped_mouse_pos)
 	}
 	#[expect(dead_code)]
@@ -671,7 +668,7 @@ impl From<CollisionAttributesId> for IntersectAttributesId{
 	}
 }
 #[derive(Debug,Clone,Copy,Hash,id::Id,Eq,PartialEq)]
-pub struct ContactModelId(u32);
+struct ContactModelId(u32);
 impl From<ContactModelId> for ModelId{
 	fn from(value:ContactModelId)->ModelId{
 		ModelId::new(value.get())
@@ -683,7 +680,7 @@ impl From<ModelId> for ContactModelId{
 	}
 }
 #[derive(Debug,Clone,Copy,Hash,id::Id,Eq,PartialEq)]
-pub struct IntersectModelId(u32);
+struct IntersectModelId(u32);
 impl From<IntersectModelId> for ModelId{
 	fn from(value:IntersectModelId)->ModelId{
 		ModelId::new(value.get())
@@ -695,7 +692,7 @@ impl From<ModelId> for IntersectModelId{
 	}
 }
 #[derive(Debug,Clone,Copy,Hash,Eq,PartialEq)]
-pub enum PhysicsModelId{
+enum PhysicsModelId{
 	Contact(ContactModelId),
 	Intersect(IntersectModelId),
 }
@@ -709,9 +706,9 @@ impl From<PhysicsModelId> for ModelId{
 }
 //unique physics meshes indexed by this
 #[derive(Debug,Clone,Copy,Eq,Hash,PartialEq)]
-pub struct ConvexMeshId<Id>{
-	pub model_id:Id,
-	pub submesh_id:PhysicsSubmeshId,
+struct ConvexMeshId<Id>{
+	model_id:Id,
+	submesh_id:PhysicsSubmeshId,
 }
 impl<Id> ConvexMeshId<Id>{
 	fn map<NewId>(self,model_id:NewId)->ConvexMeshId<NewId>{
@@ -1000,57 +997,6 @@ impl PhysicsData{
 			hitbox_mesh:StyleModifiers::default().calculate_mesh(),
 		}
 	}
-	pub fn trace_ray(&self,ray:strafesnet_common::ray::Ray)->Option<ConvexMeshId<PhysicsModelId>>{
-		let (_time,convex_mesh_id)=self.bvh.sample_ray(&ray,Time::ZERO,Time::MAX/4,|&model,ray|{
-			let mesh=self.models.mesh(model);
-			// brute force trace every face
-			let faces=mesh.faces().filter_map(|face_id|{
-				let (n,d)=mesh.face_nd(face_id);
-				// trace ray onto face
-				// n.(o+d*t)==n.p
-				// n.o + n.d * t == n.p
-				// t == (n.p - n.o)/n.d
-				let nd=n.dot(ray.direction);
-				if nd.is_zero(){
-					return None;
-				}
-				let t=(d-n.dot(ray.origin))/nd;
-				Some((face_id,t,n))
-			});
-			let mut min=None;
-			for (face_id,t,n) in faces{
-				if let Some(min)=min&&min<t{
-					continue;
-				}
-				// check if point of intersection is behind face edges
-				// *2 because average of 2 vertices
-				let p=ray.extrapolate(t)*2;
-				let is_inside_face=mesh.face_edges(face_id).as_ref().iter().all(|&directed_edge_id|{
-					let edge_n=mesh.directed_edge_n(directed_edge_id);
-					let cross_n=edge_n.cross(n);
-					let &[vert0,vert1]=mesh.edge_verts(directed_edge_id.as_undirected()).as_ref();
-					cross_n.dot(p)<cross_n.dot(mesh.vert(vert0)+mesh.vert(vert1))
-				});
-				if is_inside_face{
-					min=Some(t);
-				}
-			}
-			min.map(Into::into)
-		})?;
-		Some(*convex_mesh_id)
-	}
-	pub fn closest_fev_not_inside(&self,convex_mesh_id:ConvexMeshId<PhysicsModelId>,point:Planar64Vec3)->Option<model_physics::FEV<model_physics::MinkowskiMesh<'_>>>{
-		let model_mesh=self.models.mesh(convex_mesh_id);
-		let minkowski=model_physics::MinkowskiMesh::minkowski_sum(model_mesh,self.hitbox_mesh.transformed_mesh());
-		let fev=crate::minimum_difference::closest_fev_not_inside(&minkowski,point)?;
-		Some(fev)
-	}
-	pub fn trace(&self,convex_mesh_id:ConvexMeshId<PhysicsModelId>,body:&Body,time:Time)->Option<model_physics::FEV<model_physics::MinkowskiMesh<'_>>>{
-		let model_mesh=self.models.mesh(convex_mesh_id);
-		let minkowski=model_physics::MinkowskiMesh::minkowski_sum(model_mesh,self.hitbox_mesh.transformed_mesh());
-		let fev=crate::minimum_difference::closest_fev_not_inside(&minkowski,body.extrapolated_position(time))?;
-		Some(fev)
-	}
 	pub fn new(map:&map::CompleteMap)->Self{
 		let modes=map.modes.clone().denormalize();
 		let mut used_contact_attributes=Vec::new();
@@ -1199,9 +1145,6 @@ impl PhysicsData{
 			modes,
 		}
 	}
-	pub fn vertex_transform(&self)->&integer::Planar64Affine3{
-		&self.hitbox_mesh.transform.vertex
-	}
 }
 // the collection of information required to run physics
 pub struct PhysicsContext<'a>{
@@ -1726,20 +1669,7 @@ fn collision_start_intersect(
 			},
 			Some(gameplay_modes::Zone::Finish)=>{
 				match run.finish(time){
-					Ok(())=>{
-						let time=run.time(time);
-						let h=time.get()/(Time::ONE_SECOND.get()*60*60);
-						let m=(time.get()/(Time::ONE_SECOND.get()*60)).rem_euclid(60);
-						let s=(time.get()/(Time::ONE_SECOND.get())).rem_euclid(60);
-						let ms=(time.get()/(Time::ONE_MILLISECOND.get())).rem_euclid(1000);
-						let us=(time.get()/(Time::ONE_MICROSECOND.get())).rem_euclid(1000);
-						let ns=(time.get()/(Time::ONE_NANOSECOND.get())).rem_euclid(1000);
-						if h==0{
-							println!("@@@@ Finished run time={m:02}:{s:02}.{ms:03}_{us:03}_{ns:03}");
-						}else{
-							println!("@@@@ Finished run time={h}:{m:02}:{s:02}.{ms:03}_{us:03}_{ns:03}");
-						}
-					},
+					Ok(())=>println!("@@@@ Finished run time={}",run.time(time)),
 					Err(e)=>println!("@@@@ Run Finish error:{e:?}"),
 				}
 			},
@@ -1813,14 +1743,17 @@ fn collision_end_intersect(
 }
 fn atomic_internal_instruction(state:&mut PhysicsState,data:&PhysicsData,ins:TimedInstruction<InternalInstruction,Time>){
 	state.time=ins.time;
-	match ins.instruction{
-		// collisions advance the body precisely
+	let (should_advance_body,goober_time)=match ins.instruction{
 		InternalInstruction::CollisionStart(_,dt)
-		|InternalInstruction::CollisionEnd(_,dt)=>state.body.advance_time_ratio_dt(dt),
-		// this advances imprecisely
-		InternalInstruction::ReachWalkTargetVelocity=>state.body.advance_time(state.time),
-		// strafe tick decides for itself whether to advance the body.
-		InternalInstruction::StrafeTick=>(),
+		|InternalInstruction::CollisionEnd(_,dt)=>(true,Some(dt)),
+		InternalInstruction::StrafeTick
+		|InternalInstruction::ReachWalkTargetVelocity=>(true,None),
+	};
+	if should_advance_body{
+		match goober_time{
+			Some(dt)=>state.body.advance_time_ratio_dt(dt),
+			None=>state.body.advance_time(state.time),
+		}
 	}
 		match ins.instruction{
 			InternalInstruction::CollisionStart(collision,_)=>{
@@ -1867,8 +1800,6 @@ fn atomic_internal_instruction(state:&mut PhysicsState,data:&PhysicsData,ins:Tim
 						let masked_controls=strafe_settings.mask(controls);
 						let control_dir=state.style.get_control_dir(masked_controls);
 						if control_dir!=vec3::zero(){
-							// manually advance time
-							state.body.advance_time(state.time);
 							let camera_mat=state.camera.simulate_move_rotation_y(state.input_state.lerp_delta(state.time).x);
 							if let Some(ticked_velocity)=strafe_settings.tick_velocity(state.body.velocity,(camera_mat*control_dir).with_length(Planar64::ONE).divide().wrap_1()){
 								//this is wrong but will work ig
@@ -2041,7 +1972,7 @@ mod test{
 		let hitbox_mesh=h1.transformed_mesh();
 		let platform_mesh=h0.transformed_mesh();
 		let minkowski=model_physics::MinkowskiMesh::minkowski_sum(platform_mesh,hitbox_mesh);
-		let collision=minkowski.predict_collision_in(&relative_body,..);
+		let collision=minkowski.predict_collision_in(&relative_body,Time::ZERO..Time::from_secs(10));
 		assert_eq!(collision.map(|tup|relative_body.time+tup.1.into()),expected_collision_time,"Incorrect time of collision");
 	}
 	fn test_collision_rotated(relative_body:Body,expected_collision_time:Option<Time>){
@@ -2059,7 +1990,7 @@ mod test{
 		let hitbox_mesh=h1.transformed_mesh();
 		let platform_mesh=h0.transformed_mesh();
 		let minkowski=model_physics::MinkowskiMesh::minkowski_sum(platform_mesh,hitbox_mesh);
-		let collision=minkowski.predict_collision_in(&relative_body,..);
+		let collision=minkowski.predict_collision_in(&relative_body,Time::ZERO..Time::from_secs(10));
 		assert_eq!(collision.map(|tup|relative_body.time+tup.1.into()),expected_collision_time,"Incorrect time of collision");
 	}
 	fn test_collision(relative_body:Body,expected_collision_time:Option<Time>){

engine/session/src/session.rs

@@ -48,7 +48,6 @@ pub enum SessionControlInstruction{
 	StopSpectate,
 	SaveReplay,
 	LoadIntoReplayState,
-	DebugSimulation,
 }
 pub enum SessionPlaybackInstruction{
 	SkipForward,
@@ -61,8 +60,6 @@ pub struct FrameState{
 	pub body:physics::Body,
 	pub camera:physics::PhysicsCamera,
 	pub time:PhysicsTime,
-	pub hit:Option<Hit>,
-	pub debug_hitbox_position:Option<strafesnet_common::integer::Planar64Affine3>,
 }
 
 pub struct Simulation{
@@ -79,38 +76,11 @@ impl Simulation{
 			physics,
 		}
 	}
-	pub fn get_frame_state(
-		&self,
-		time:SessionTime,
-		debug_model:Option<Hit>,
-		debug_hitbox_position:Option<strafesnet_common::integer::Planar64Affine3>,
-	)->FrameState{
+	pub fn get_frame_state(&self,time:SessionTime)->FrameState{
 		FrameState{
 			body:self.physics.camera_body(),
 			camera:self.physics.camera(),
 			time:self.timer.time(time),
-			hit:debug_model,
-			debug_hitbox_position,
-		}
-	}
-}
-
-// a paused simulation which displays a period of its future traced over the model under the cursor
-struct DebugSimulation{
-	physics:physics::PhysicsState,
-	timer:strafesnet_common::timer::TimerFixed<Scaled<SessionTimeInner,PhysicsTimeInner>,strafesnet_common::timer::Paused>,
-	cycle_duration:PhysicsTime,
-}
-impl DebugSimulation{
-	pub fn new(simulation:&Simulation,time:SessionTime,cycle_duration:PhysicsTime)->Self{
-		let timer=match &simulation.timer{
-			Timer::Paused(timer_fixed)=>*timer_fixed,
-			Timer::Unpaused(timer_fixed)=>timer_fixed.into_paused(time),
-		};
-		Self{
-			physics:simulation.physics.clone(),
-			timer,
-			cycle_duration,
 		}
 	}
 }
@@ -178,12 +148,6 @@ enum ViewState{
 	Replay(BotId),
 }
 
-#[derive(Clone)]
-pub struct Hit{
-	pub convex_mesh_id:physics::ConvexMeshId<physics::PhysicsModelId>,
-	pub closest_fev:Option<strafesnet_physics::model::FEV<strafesnet_physics::model::TransformedMesh<'static>>>
-}
-
 pub struct Session{
 	directories:Directories,
 	user_settings:UserSettings,
@@ -196,8 +160,6 @@ pub struct Session{
 	recording:Recording,
 	//players:HashMap<PlayerId,Simulation>,
 	replays:HashMap<BotId,Replay>,
-	last_ray_hit:Option<Hit>,
-	debug_simulation:Option<DebugSimulation>,
 }
 impl Session{
 	pub fn new(
@@ -214,8 +176,6 @@ impl Session{
 			view_state:ViewState::Play,
 			recording:Default::default(),
 			replays:HashMap::new(),
-			last_ray_hit:None,
-			debug_simulation:None,
 		}
 	}
 	fn clear_recording(&mut self){
@@ -226,45 +186,13 @@ impl Session{
 		self.geometry_shared=PhysicsData::new(map);
 	}
 	pub fn get_frame_state(&self,time:SessionTime)->Option<FrameState>{
-		let debug_hitbox_position=self.debug_simulation.as_ref().map(|debug_simulation|{
-			let simulation_time=debug_simulation.timer.time();
-			let loop_time=simulation_time+PhysicsTime::raw(time.get().rem_euclid(debug_simulation.cycle_duration.get())>>1);
-			let transform=self.geometry_shared.vertex_transform();
-			strafesnet_common::integer::Planar64Affine3::new(transform.matrix3,debug_simulation.physics.body().extrapolated_position(loop_time))
-		});
 		match &self.view_state{
-			ViewState::Play=>Some(self.simulation.get_frame_state(time,self.last_ray_hit.clone(),debug_hitbox_position)),
+			ViewState::Play=>Some(self.simulation.get_frame_state(time)),
 			ViewState::Replay(bot_id)=>self.replays.get(bot_id).map(|replay|
-				replay.simulation.get_frame_state(time,None,debug_hitbox_position)
+				replay.simulation.get_frame_state(time)
 			),
 		}
 	}
-	pub fn debug_raycast_print_model_id_if_changed(&mut self,time:SessionTime){
-		let Some(debug_simulation)=&self.debug_simulation else{
-			return;
-		};
-		if let Some(frame_state)=self.get_frame_state(time){
-			let ray=strafesnet_common::ray::Ray{
-				origin:frame_state.body.extrapolated_position(self.simulation.timer.time(time)),
-				direction:-frame_state.camera.rotation().z_axis,
-			};
-			match self.geometry_shared.trace_ray(ray){
-				Some(convex_mesh_id)=>{
-					if self.last_ray_hit.as_ref().map_or(true,|last|last.convex_mesh_id!=convex_mesh_id){
-						println!("MeshId={convex_mesh_id:?}");
-					}
-					let simulation_time=debug_simulation.timer.time();
-					let loop_time=simulation_time+PhysicsTime::raw(time.get().rem_euclid(debug_simulation.cycle_duration.get())>>1);
-					let closest_fev=self.geometry_shared.trace(convex_mesh_id,debug_simulation.physics.body(),loop_time);
-					self.last_ray_hit=Some(Hit{
-						convex_mesh_id,
-						closest_fev:closest_fev.map(|fev|fev.mesh0()),
-					});
-				},
-				None=>self.last_ray_hit=None,
-			}
-		}
-	}
 	pub fn user_settings(&self)->&UserSettings{
 		&self.user_settings
 	}
@@ -480,10 +408,6 @@ impl InstructionConsumer<Instruction<'_>> for Session{
 				// begin spectate
 				self.view_state=ViewState::Replay(bot_id);
 			},
-			Instruction::Control(SessionControlInstruction::DebugSimulation)=>{
-				println!("Body={}",self.simulation.physics.body());
-				self.debug_simulation=Some(DebugSimulation::new(&self.simulation,ins.time,PhysicsTime::ONE_SECOND<<1));
-			},
 			Instruction::Idle=>{
 				run_mouse_interpolator_instruction!(MouseInterpolatorInstruction::Idle);
 				// this just refreshes the replays

integration-testing/src/tests.rs

@@ -60,12 +60,8 @@ fn physics_bug_3()->Result<(),ReplayError>{
 		// vec3::raw_xyz(0,-96915585363,1265),
 		// vec3::raw_xyz(0,-429496729600,0),
 		// corner setup before wall hits
-		// vec3::raw_xyz(-1392580080675,3325402529458,-2444727738679),
-		// vec3::raw_xyz(-30259028820,-22950929553,-71141663007),
-		// vec3::raw_xyz(0,-429496729600,0),
-		// Actual bug 3 repro
-		vec3::raw_xyz(-2505538624455,3357963283914,557275711118),
-		vec3::raw_xyz(204188283920,-282280474198,166172785440),
+		vec3::raw_xyz(-1392580080675,3325402529458,-2444727738679),
+		vec3::raw_xyz(-30259028820,-22950929553,-71141663007),
 		vec3::raw_xyz(0,-429496729600,0),
 		Time::ZERO,
 	);

strafe-client/src/physics_worker.rs

@@ -59,10 +59,6 @@ pub fn new<'a>(
 			},
 			Instruction::Render=>{
 				run_session_instruction!(ins.time,SessionInstruction::Idle);
-
-				// update model under cursor
-				session.debug_raycast_print_model_id_if_changed(ins.time);
-
 				if let Some(frame_state)=session.get_frame_state(ins.time){
 					run_graphics_worker_instruction!(GraphicsInstruction::Render(frame_state));
 				}

strafe-client/src/setup.rs

@@ -3,7 +3,7 @@ fn optional_features()->wgpu::Features{
 	|wgpu::Features::TEXTURE_COMPRESSION_ETC2
 }
 fn required_features()->wgpu::Features{
-	wgpu::Features::TEXTURE_COMPRESSION_BC|wgpu::Features::EXPERIMENTAL_MESH_SHADER
+	wgpu::Features::TEXTURE_COMPRESSION_BC
 }
 fn required_downlevel_capabilities()->wgpu::DownlevelCapabilities{
 	wgpu::DownlevelCapabilities{
@@ -125,7 +125,7 @@ impl<'a> SetupContextPartial3<'a>{
 					required_limits:needed_limits,
 					memory_hints:wgpu::MemoryHints::Performance,
 					trace:wgpu::Trace::Off,
-					experimental_features:unsafe{wgpu::ExperimentalFeatures::enabled()},
+					experimental_features:wgpu::ExperimentalFeatures::disabled(),
 				},
 			))
 			.expect("Unable to find a suitable GPU adapter!");

strafe-client/src/shader.wgsl

@@ -1,5 +1,3 @@
-enable wgpu_mesh_shader;
-
 struct Camera {
 	// from camera to screen
 	proj: mat4x4<f32>,
@@ -88,166 +86,6 @@ fn vs_entity_texture(
 	return result;
 }
 
-@group(1)
-@binding(0)
-var<uniform> model_instance: ModelInstance;
-
-@group(1)
-@binding(1)
-var<uniform> ve_verts: array<vec4<f32>, 2>;
-
-struct DebugEntityOutput {
-	@builtin(position) position: vec4<f32>,
-};
-
-@vertex
-fn vs_debug(
-	@location(0) pos: vec3<f32>,
-) -> DebugEntityOutput {
-	var position: vec4<f32> = model_instance.transform * vec4<f32>(pos, 1.0);
-	var result: DebugEntityOutput;
-	result.position = camera.proj * camera.view * position;
-	return result;
-}
-
-struct TaskPayload {
-    four_bytes: u32,
-}
-
-var<task_payload> taskPayload: TaskPayload;
-
-@task
-@payload(taskPayload)
-@workgroup_size(1)
-fn ts_main() -> @builtin(mesh_task_size) vec3<u32> {
-	taskPayload.four_bytes = 0;
-	return vec3(1, 1, 1);
-}
-
-struct VertexOutput {
-	@builtin(position) position: vec4<f32>,
-	@location(0) color: vec4<f32>,
-}
-struct PrimitiveOutput {
-	@builtin(triangle_indices) indices: vec3<u32>,
-}
-
-struct CircleOutput {
-	@builtin(vertices) vertices: array<VertexOutput, 24>,
-	@builtin(primitives) primitives: array<PrimitiveOutput, 22>,
-	@builtin(vertex_count) vertex_count: u32,
-	@builtin(primitive_count) primitive_count: u32,
-}
-
-var<workgroup> mesh_output: CircleOutput;
-
-const tau: f32 = 3.141592653589793 * 2.0;
-
-fn modulo(value:u32,modulus:u32)->u32{
-	return value-value/modulus*modulus;
-}
-
-@mesh(mesh_output)
-@payload(taskPayload)
-@workgroup_size(1)
-fn ms_debug_vert(){
-	// circle with 24 vertices.
-	const LAYERS:u32 = 3;
-	const N:u32 = 3*(1<<LAYERS);
-	mesh_output.vertex_count = N;
-	mesh_output.primitive_count = N-2;
-
-	var vertex_world_position: vec4<f32> = model_instance.transform * ve_verts[0];
-	var vertex_screen_position: vec4<f32> = camera.proj * camera.view * vertex_world_position;
-
-	for (var i:u32 = 0; i<N/4; i++){
-		// draw a 1 unit redius circle
-		var theta: f32 = f32(i) * tau / f32(N);
-		var cos_sin: vec2<f32> = vec2(cos(theta), sin(theta));
-		var offset: vec2<f32> = 0.5 * cos_sin;
-		mesh_output.vertices[i].position = vertex_screen_position + vec4<f32>(offset, 0.0, 0.0);
-		mesh_output.vertices[i+N/4].position = vertex_screen_position + vec4<f32>(-offset.y, offset.x, 0.0, 0.0);
-		mesh_output.vertices[i+N/4*2].position = vertex_screen_position + vec4<f32>(-offset, 0.0, 0.0);
-		mesh_output.vertices[i+N/4*3].position = vertex_screen_position + vec4<f32>(offset.y, -offset.x, 0.0, 0.0);
-	}
-
-	// max area triangle indices
-
-	// the big triangle
-	mesh_output.primitives[0].indices = vec3<u32>(0, N/3, N/3*2);
-
-	// 3 layers of infill triangles to approximate circle better than 1 triangle.
-	// we start on the outer layer because it's easier to construct this way
-	var count:u32=N;
-	var base:u32=1;
-	for (var layer:u32 = 0; layer<LAYERS; layer++){
-		count=count>>1;
-		var step:u32=N/count;
-		for (var i:u32 = 0; i<count; i++){
-			mesh_output.primitives[base+i].indices = vec3<u32>(i*step, i*step+(step>>1), modulo(i*step+step,N));
-		}
-		base+=count;
-	}
-}
-
-@mesh(mesh_output)
-@payload(taskPayload)
-@workgroup_size(1)
-fn ms_debug_edge(){
-	// draw two circles for now.
-	const LAYERS:u32 = 3;
-	const N:u32 = 2*(1<<LAYERS);
-	mesh_output.vertex_count = 2*(3+2+4+8);
-	mesh_output.primitive_count = 2*(1+2+4+8)+2;
-
-	var v0_world_position: vec4<f32> = model_instance.transform * ve_verts[0];
-	var v1_world_position: vec4<f32> = model_instance.transform * ve_verts[1];
-
-	var v0_screen_position: vec4<f32> = camera.proj * camera.view * v0_world_position;
-	var v1_screen_position: vec4<f32> = camera.proj * camera.view * v1_world_position;
-
-	var edge_dir_world: vec4<f32> = normalize(v0_world_position - v1_world_position);
-	var edge_dir_screen: vec4<f32> = camera.proj * camera.view * edge_dir_world;
-
-	for (var i:u32 = 0; i<=N/2; i++){
-		// two half circles that make a whole
-		var theta: f32 = f32(i) * tau / f32(N);
-		var cos_sin: vec2<f32> = vec2(cos(theta), sin(theta));
-
-		// construct basis vectors
-		var y_axis: vec2<f32> = edge_dir_screen.xy;
-		var x_axis: vec2<f32> = y_axis.yx;
-		x_axis.x = -x_axis.x;
-
-		var offset: vec4<f32> = vec4<f32>(0.5 * (x_axis * cos_sin.x + y_axis * cos_sin.y), 0.0, 0.0);;
-
-		mesh_output.vertices[i].position = v0_screen_position + offset;
-		mesh_output.vertices[N/2+1+i].position = v1_screen_position - offset;
-	}
-
-	// max area triangle indices
-	// number of primitives per circle half
-	const P:u32 = N/2;
-	// the big triangles between the circles
-	mesh_output.primitives[0].indices = vec3<u32>(0, N/2+1, P);
-	mesh_output.primitives[P].indices = vec3<u32>(N/2+1, 0, P + N/2+1);
-
-	// 3 layers of infill triangles to approximate circle better than 1 triangle.
-	// we start on the outer layer because it's easier to construct this way
-	var count:u32=P;
-	var base:u32=1;
-	for (var layer:u32 = 0; layer<LAYERS; layer++){
-		count=count>>1;
-		var step:u32=P/count;
-		for (var i:u32 = 0; i<count; i++){
-			var indices = vec3<u32>(i*step, i*step+(step>>1), i*step+step);
-			mesh_output.primitives[base+i].indices = indices;
-			mesh_output.primitives[P+base+i].indices = indices + N/2+1;
-		}
-		base+=count;
-	}
-}
-
 //group 2 is the skybox texture
 @group(1)
 @binding(0)
@@ -272,8 +110,3 @@ fn fs_entity_texture(vertex: EntityOutputTexture) -> @location(0) vec4<f32> {
 	let reflected_color = textureSample(cube_texture, cube_sampler, reflected).rgb;
 	return mix(vec4<f32>(vec3<f32>(0.05) + 0.2 * reflected_color,1.0),mix(vertex.model_color,vec4<f32>(fragment_color.rgb,1.0),fragment_color.a),0.5+0.5*abs(d));
 }
-
-@fragment
-fn fs_debug(vertex: DebugEntityOutput) -> @location(0) vec4<f32> {
-	return model_instance.color;
-}

strafe-client/src/window.rs

@@ -171,7 +171,6 @@ impl WindowContext<'_>{
 								"X"|"x"=>session_ctrl!(StopSpectate,s),
 								"N"|"n"=>session_ctrl!(SaveReplay,s),
 								"J"|"j"=>session_ctrl!(LoadIntoReplayState,s),
-								"H"|"h"=>session_ctrl!(DebugSimulation,s),
 								_=>None,
 							},
 							_=>None,